Skip to content
This repository has been archived by the owner on Aug 13, 2024. It is now read-only.

[KIP-146] Unpredictable proposer selection policy #147

Merged
merged 20 commits into from
Jul 13, 2023
Merged

[KIP-146] Unpredictable proposer selection policy #147

merged 20 commits into from
Jul 13, 2023

Conversation

ian0371
Copy link
Contributor

@ian0371 ian0371 commented Jun 19, 2023

KIP-146 is a proposal for unpredictable proposer selection policy.
See this PR in markdown
Closes #146

@ian0371 ian0371 marked this pull request as draft June 20, 2023 02:43
@steve-jeon-KF
Copy link

steve-jeon-KF commented Jun 20, 2023

I leave this comment based on today's scrum for other members to be aligned. In KIP-146, the proposer is determined by shuffling without using a Picker and selecting the address at index 0. And to prevent duplicates, the selected proposer is excluded for the next round, and a shuffle is performed for each round.

KIPs/kip-146.md Outdated Show resolved Hide resolved
KIPs/kip-146.md Outdated Show resolved Hide resolved
KIPs/kip-146.md Outdated Show resolved Hide resolved
@ian0371 ian0371 marked this pull request as ready for review June 26, 2023 11:50
KIPs/kip-146.md Outdated Show resolved Hide resolved
KIPs/kip-146.md Outdated Show resolved Hide resolved
KIPs/kip-146.md Outdated Show resolved Hide resolved
KIPs/kip-146.md Outdated Show resolved Hide resolved
ian0371 and others added 2 commits June 27, 2023 13:38
Co-authored-by: Junghyun Colin Kim <colin.klaytn@krustuniverse.com>
Copy link

@hyunsooda hyunsooda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor issue: A function have type signatures, another function does not have. Making align seems look better.

KIPs/kip-146.md Show resolved Hide resolved
KIPs/kip-146.md Show resolved Hide resolved
KIPs/kip-146.md Show resolved Hide resolved
@ian0371 ian0371 changed the title [KIP-146] Random proposer selection policy [KIP-146] Unpredictable proposer selection policy Jul 4, 2023
@ian0371 ian0371 requested a review from neoofklaytn as a code owner July 4, 2023 06:40
@ian0371
Copy link
Contributor Author

ian0371 commented Jul 4, 2023

Changes

  • in title, random -> unpredictable
  • removed the term "Round robin"
  • spec change
    • committee does not change in case of round change
    • proposer is selected from the committee
  • add rationale

@kjhman21
Copy link
Collaborator

kjhman21 commented Jul 8, 2023

@hyunsooda @jiseongnoh Please approve this one if you guys have no more questions and suggestions.

@hyunsooda
Copy link

@ian0371, regarding the recently introduced concept of a fixed committee at round change, is there any underlying rationale or basis for this hypothesis? I have an additional concern regarding the presence of an adversary within the committee, as it seems they could continuously disrupt the consensus if the committee remains fixed until the next block number.

Apologies for the confusion, I'm unsure whether this question should be posted here or as a new issue.

@kjhman21 kjhman21 merged commit 373b00f into main Jul 13, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jul 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discussion for Unpredictable Proposer Selection Policy
5 participants