This repository has been archived by the owner on Aug 13, 2024. It is now read-only.
[KIP-113] An interface compatible with CandidateList #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ian0371
requested review from
kjhman21,
neoofklaytn,
aidan-kwon,
blukat29 and
scott-klaytn
as code owners
blukat29
approved these changes
Oct 11, 2023
hyeonLewis
reviewed
Oct 18, 2023
Co-authored-by: Lewis <lewis.kim@klaytn.foundation>
hyeonLewis
approved these changes
Oct 24, 2023
9 tasks
aidan-kwon
reviewed
Oct 30, 2023
|
@aidan-kwon Register function is only removed from the spec, because we cannot implement a function with the same prototype in CandidateList. You can refer to the simple bls registry implementation here: https://github.com/klaytn/system-contracts/blob/main/contracts/consensus/SimpleBlsRegistry.sol#L61-L73 |
|
@kjhman21 @aidan-kwon This PR minizes the interface so that "KIP-113" can be implemented by the current SimpleBLSRegistry and upcoming CandidateList. Registration logic is up to the implementation and perhaps defined in future specs. PTAL. |
blukat29
approved these changes
Dec 22, 2023
blukat29
changed the title
kjhman21
approved these changes
Dec 26, 2023
aidan-kwon
approved these changes
Dec 26, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the interface compatible with CandidateList.
This facilitates migration from SimpleBLSRegistry to CandidateList, as the consensus logic of Klaytn nodes need not change.