This repository has been archived by the owner on Aug 13, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyeonLewis
requested review from
kjhman21,
neoofklaytn,
aidan-kwon,
blukat29,
ian0371 and
scott-klaytn
as code owners
February 7, 2024 06:56
hyeonLewis
force-pushed
the
add-randao-api
branch
from
February 7, 2024 11:04
679698a
to
d4307b8
Compare
hyeonLewis
force-pushed
the
add-randao-api
branch
from
February 7, 2024 12:30
d4307b8
to
43c683f
Compare
kjhman21
reviewed
Feb 13, 2024
kjhman21
reviewed
Feb 13, 2024
kjhman21
reviewed
Feb 13, 2024
kjhman21
reviewed
Feb 13, 2024
kjhman21
approved these changes
Feb 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update.
ian0371
approved these changes
Feb 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe consider adding error codes later (after implementation), like this
@blukat29 PTAL |
blukat29
approved these changes
Feb 14, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KIP113
klay_getBlsInfos
: Returns all registered BLS records inSImpleBlsRegistry
contract (KIP113)KIP149
klay_getAllRecordsFromRegistry
: Returns all registered records inRegistry
contract (KIP14)klay_getActiveAddressFromRegistry
: Returns active address inRegistry
contract if existsAny suggestions for improvements are welcome.