Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Support AWS IAM auth for Vault provider #228

Closed
missedone opened this issue Sep 3, 2023 · 3 comments
Closed

Proposal: Support AWS IAM auth for Vault provider #228

missedone opened this issue Sep 3, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@missedone
Copy link
Contributor

the Vault go SDK support AWS IAM as the auth method, so that the app doesn't necessarily need to hold the auth token which could be a risk, because securing the vault token becomes a challenging task.

i think we can introduce an new field authMethod in Vault config struct https://github.com/knadh/koanf/blob/master/providers/vault/vault.go#L15
we may use token as the default method to keep the back compatibility

ref:

  1. https://developer.hashicorp.com/vault/docs/auth/aws
  2. https://github.com/hashicorp/vault-examples/blob/main/examples/auth-methods/aws/go/example.go
@missedone missedone added the bug Something isn't working label Sep 3, 2023
@missedone
Copy link
Contributor Author

one thing you might not like, if we start supporting AWS IAM auth, people may ask for supporting other methods listed here https://developer.hashicorp.com/vault/docs/auth

it could ends with a lot dependencies for Vault Provider

@missedone
Copy link
Contributor Author

so i'd like to propose the AuthMethod field that leave the complicity out of Koanf: #229

@missedone
Copy link
Contributor Author

closes the issue which is solved in #229

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant