From 6a9c44478c2d9ab8db9044d1b3c059afd20d7f44 Mon Sep 17 00:00:00 2001 From: Knative Prow Robot Date: Thu, 2 Mar 2023 08:32:31 +0000 Subject: [PATCH] Use kubernetes.io/metadata.name for namespace selector (#2993) Instead of using the custom `app.kubernetes.io/name` for selecting a specific namespace we use the `kubernetes.io/metadata.name` label that is enforced by the API server on each namespace https://kubernetes.io/docs/reference/labels-annotations-taints/#kubernetes-io-metadata-name The benefit is that some installations create the system namespace themself so the app.kubernetes.io/name that is defined in core might not be present, leading to a non functioning KafkaSource. Signed-off-by: Pierangelo Di Pilato Co-authored-by: Pierangelo Di Pilato --- .../200-webhook/400-webhook-pod-defaulting.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/control-plane/config/eventing-kafka-broker/200-webhook/400-webhook-pod-defaulting.yaml b/control-plane/config/eventing-kafka-broker/200-webhook/400-webhook-pod-defaulting.yaml index 6fa59dd05b..54a451a598 100644 --- a/control-plane/config/eventing-kafka-broker/200-webhook/400-webhook-pod-defaulting.yaml +++ b/control-plane/config/eventing-kafka-broker/200-webhook/400-webhook-pod-defaulting.yaml @@ -33,7 +33,7 @@ webhooks: matchPolicy: Equivalent namespaceSelector: matchLabels: - app.kubernetes.io/name: knative-eventing + kubernetes.io/metadata.name: knative-eventing objectSelector: matchLabels: app.kubernetes.io/component: kafka-dispatcher