Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document transport-encryption Eventing feature #5642

Merged
merged 4 commits into from
Aug 3, 2023

Conversation

pierDipi
Copy link
Member

@pierDipi pierDipi commented Jul 28, 2023

Fixes #5525

Proposed Changes

  • Document transport-encryption feature

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 28, 2023
@knative-prow knative-prow bot requested review from pmbanugo and psschwei July 28, 2023 14:42
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2023
@netlify
Copy link

netlify bot commented Jul 28, 2023

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 517b6c2
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/64cb7f44fd5ff60007d00ac2
😎 Deploy Preview https://deploy-preview-5642--knative.netlify.app/docs/eventing/experimental-features/transport-encryption
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 28, 2023
@ReToCode
Copy link
Member

Do you want to add a navbar item for it as well?

@matzew
Copy link
Member

matzew commented Aug 3, 2023

name: config-features
namespace: knative-eventing
data:
transport-encryption: "strict"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did just the kubectl apply from here: https://cert-manager.io/docs/installation/

k get pods -A
NAMESPACE            NAME                                         READY   STATUS    RESTARTS   AGE
cert-manager         cert-manager-5f68c9c6dd-tcms7                1/1     Running   0          2m8s
cert-manager         cert-manager-cainjector-57d6fc9f7d-kh5jc     1/1     Running   0          2m8s
cert-manager         cert-manager-webhook-5b7ffbdc98-zjzvz        1/1     Running   0          2m8s

set the value to strict, and created a broker. Result:

default     my-broker         1s    False   NoAddress

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed that we need to apply the new Eventing TLS artifact from the release assets

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had it installed via ko apply -f config/tls/issuers

same (using the upstream 1.11 branch)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not enough, you need certificates as well

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like should be listed in the doc

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, doing:

➜  eventing git:(1a5f37cdf) k apply -f https://github.com/knative/eventing/releases/download/knative-v1.11.0/eventing-tls-networking.yaml

fixed it 😉

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 3, 2023
pierDipi and others added 2 commits August 3, 2023 12:10
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
@pierDipi pierDipi changed the title [WIP] Document transport-encryption feature Document transport-encryption feature Aug 3, 2023
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 3, 2023
@pierDipi pierDipi changed the title Document transport-encryption feature Document transport-encryption Eventing feature Aug 3, 2023
@pierDipi pierDipi requested a review from matzew August 3, 2023 10:29
Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 3, 2023
@knative-prow
Copy link

knative-prow bot commented Aug 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@matzew
Copy link
Member

matzew commented Aug 3, 2023

/cherry-pick release-1.11

@knative-prow-robot
Copy link
Contributor

@matzew: once the present PR merges, I will cherry-pick it on top of release-1.11 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot merged commit c9f29b9 into knative:main Aug 3, 2023
17 checks passed
@knative-prow-robot
Copy link
Contributor

@matzew: new pull request created: #5655

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Eventing TLS: Documentation
4 participants