Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop use of https://github.com/gorilla/websocket #6861

Closed
Gekko0114 opened this issue Apr 15, 2023 · 2 comments
Closed

Drop use of https://github.com/gorilla/websocket #6861

Gekko0114 opened this issue Apr 15, 2023 · 2 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. triage/accepted Issues which should be fixed (post-triage)

Comments

@Gekko0114
Copy link

https://github.com/gorilla/websocket is deprecated and unmaintained.
We should switch to something that is and ensure everything works as expected (ie. draining in queue proxy etc).

Releated to knative/serving#13824 knative/pkg#2727
@Gekko0114 Gekko0114 added the kind/bug Categorizes issue or PR as related to a bug. label Apr 15, 2023
@Gekko0114
Copy link
Author

/assign

@pierDipi pierDipi added the triage/accepted Issues which should be fixed (post-triage) label Apr 17, 2023
@Gekko0114 Gekko0114 mentioned this issue Apr 29, 2023
Closed
5 tasks
@Gekko0114
Copy link
Author

We no longer need to replace gorilla/websocket with gobwas/ws.
Further information is here. knative/serving#13824
/unassign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug. triage/accepted Issues which should be fixed (post-triage)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

use gobwas/ws instead of gorilla/websocket Gekko0114/eventing
3 participants
@dprotaso @pierDipi @Gekko0114