From 2b6388e18530b3c0245bce6b5a76f10423d757fd Mon Sep 17 00:00:00 2001
From: Izabela Gomes <igomes@vmware.com>
Date: Wed, 29 May 2024 12:06:15 -0400
Subject: [PATCH] revert headless svc change from k8s private svc

---
 pkg/reconciler/serverlessservice/resources/services.go      | 3 +--
 pkg/reconciler/serverlessservice/resources/services_test.go | 2 --
 2 files changed, 1 insertion(+), 4 deletions(-)

diff --git a/pkg/reconciler/serverlessservice/resources/services.go b/pkg/reconciler/serverlessservice/resources/services.go
index 94f406cce905..5672fc12e3df 100644
--- a/pkg/reconciler/serverlessservice/resources/services.go
+++ b/pkg/reconciler/serverlessservice/resources/services.go
@@ -188,8 +188,7 @@ func MakePrivateService(sks *v1alpha1.ServerlessService, selector map[string]str
 				Port:       targetPort(sks).IntVal,
 				TargetPort: targetPort(sks),
 			}},
-			Selector:  selector,
-			ClusterIP: corev1.ClusterIPNone,
+			Selector: selector,
 		},
 	}
 }
diff --git a/pkg/reconciler/serverlessservice/resources/services_test.go b/pkg/reconciler/serverlessservice/resources/services_test.go
index 04fb30a9b964..0690f52d3d07 100644
--- a/pkg/reconciler/serverlessservice/resources/services_test.go
+++ b/pkg/reconciler/serverlessservice/resources/services_test.go
@@ -133,7 +133,6 @@ func privateSvcMod(s *corev1.Service) {
 			"app": "sadness",
 		}
 	}
-	s.Spec.ClusterIP = corev1.ClusterIPNone
 	s.Spec.Ports = append(s.Spec.Ports,
 		[]corev1.ServicePort{{
 			Name:       servingv1.AutoscalingQueueMetricsPortName,
@@ -471,7 +470,6 @@ func TestMakePrivateService(t *testing.T) {
 			s.Labels["ava"] = "adore"
 			s.Labels[networking.SKSLabelKey] = "dream-tonight-cherub-rock-mayonnaise-hummer-disarm-rocket-soma-quiet"
 			s.Annotations = map[string]string{"cherub": "rock"}
-			s.Spec.ClusterIP = corev1.ClusterIPNone
 		}, privateSvcMod, func(s *corev1.Service) {
 			// And now patch port to be http2.
 			s.Spec.Ports[0] = corev1.ServicePort{