From 6c9252f915f41ee88d15a9170cc1dfb957f9d4e0 Mon Sep 17 00:00:00 2001 From: Izabela Gomes Date: Wed, 5 Jun 2024 16:44:11 -0400 Subject: [PATCH] rename test cases --- pkg/deployment/config_test.go | 10 +++++----- pkg/reconciler/revision/resources/deploy_test.go | 6 +++--- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/pkg/deployment/config_test.go b/pkg/deployment/config_test.go index 5e3113b17efa..b4965126d5fd 100644 --- a/pkg/deployment/config_test.go +++ b/pkg/deployment/config_test.go @@ -81,7 +81,7 @@ func TestControllerConfiguration(t *testing.T) { wantConfig *Config data map[string]string }{{ - name: "controller configuration with no affinity rule specified", + name: "controller configuration with no default affinity type specified", wantConfig: &Config{ RegistriesSkippingTagResolving: sets.New("kind.local", "ko.local", "dev.local"), DigestResolutionTimeout: digestResolutionTimeoutDefault, @@ -95,21 +95,21 @@ func TestControllerConfiguration(t *testing.T) { QueueSidecarImageKey: defaultSidecarImage, }, }, { - name: "controller configuration with empty string for the affinity rule", + name: "controller configuration with empty string set for the default affinity type", wantErr: true, data: map[string]string{ QueueSidecarImageKey: defaultSidecarImage, defaultAffinityTypeKey: "", }, }, { - name: "controller configuration with unsupported affinity value", + name: "controller configuration with unsupported value for default affinity type", wantErr: true, data: map[string]string{ QueueSidecarImageKey: defaultSidecarImage, defaultAffinityTypeKey: "coconut", }, }, { - name: "controller configuration with the default affinity rule set", + name: "controller configuration with the default affinity type set", wantConfig: &Config{ RegistriesSkippingTagResolving: sets.New("kind.local", "ko.local", "dev.local"), DigestResolutionTimeout: digestResolutionTimeoutDefault, @@ -124,7 +124,7 @@ func TestControllerConfiguration(t *testing.T) { defaultAffinityTypeKey: string(PreferSpreadRevisionOverNodes), }, }, { - name: "controller configuration with affinity deactivated", + name: "controller configuration with default affinity type deactivated", wantConfig: &Config{ RegistriesSkippingTagResolving: sets.New("kind.local", "ko.local", "dev.local"), DigestResolutionTimeout: digestResolutionTimeoutDefault, diff --git a/pkg/reconciler/revision/resources/deploy_test.go b/pkg/reconciler/revision/resources/deploy_test.go index e0326fdedb5c..bf1038130499 100644 --- a/pkg/reconciler/revision/resources/deploy_test.go +++ b/pkg/reconciler/revision/resources/deploy_test.go @@ -1435,7 +1435,7 @@ func TestMakePodSpec(t *testing.T) { ), }), }, { - name: "with default affinity rules", + name: "with default affinity type set", rev: revision("bar", "foo", withContainers([]corev1.Container{{ Name: servingContainerName, @@ -1466,7 +1466,7 @@ func TestMakePodSpec(t *testing.T) { }, ), }, { - name: "with affinity rules deactivated", + name: "with default affinity type deactivated", rev: revision("bar", "foo", withContainers([]corev1.Container{{ Name: servingContainerName, @@ -1492,7 +1492,7 @@ func TestMakePodSpec(t *testing.T) { }, ), }, { - name: "with affinity rules set by the user and the operator", + name: "with affinity rules set by both the user and the operator", rev: revision("bar", "foo", withContainers([]corev1.Container{{ Name: servingContainerName,