Need a post-install job to clean up domain mapping webhook resources

[dprotaso]

When we merged the domain mapping webhook in #14082 older installations leave resources around.

The release notes didn't specify how clean up the resources. In theory we could create a k8s post-install job that'll do the deletion.

I think we should use a job because folks who use the operator don't do the manual steps

[dprotaso]

/assign @skonto

[skonto]

@dprotaso is not this kind of a bit too late? This is many releases back no? People have already upgraded to newer versions and we support specific range of versions, no?
Are we planning to backport if we create such a job?

I think we should use a job because folks who use the operator don't do the manual steps

I think that is the operator's work to make sure that the desired state is reflected on the cluster per version, no?
Is there some issue that is related to this request?

[dprotaso]

I think that is the operator's work to make sure that the desired state is reflected on the cluster per version, no?

Can you confirm if the operator deletes the older components? If so then we can close this out.

[skonto]

Operator removes stuff, part of its logic. I tried the upgrade from 1.10.2 to 1.11.0 (merged dms).

$ kubectl get po -n knative-serving
NAME                                      READY   STATUS    RESTARTS   AGE
3scale-kourier-gateway-5dfb69fb86-dtb5v   1/1     Running   0          22m
activator-7f86fb77f8-ths68                1/1     Running   0          23m
autoscaler-657cb48c96-jmwjp               1/1     Running   0          23m
autoscaler-hpa-cf56d8bcc-5f8nk            1/1     Running   0          23m
controller-5649857ccc-5bjbv               1/1     Running   0          23m
domain-mapping-5ffd4df948-rcgxr           1/1     Running   0          23m
domainmapping-webhook-859df874cb-x7gsd    1/1     Running   0          23m
net-kourier-controller-76d9448d7b-54lxn   1/1     Running   0          22m
webhook-74b6f5cf75-w8gpj                  1/1     Running   0          23m

Patch with:

apiVersion: operator.knative.dev/v1beta1
kind: KnativeServing
metadata:
  name: knative-serving
  namespace: knative-serving
spec:
  version: "1.11.0"

$ kubectl get po -n knative-serving
NAME                                                     READY   STATUS              RESTARTS   AGE
3scale-kourier-gateway-5dfb69fb86-dtb5v                  1/1     Running             0          22m
3scale-kourier-gateway-77755d86dc-hkmh2                  0/1     ContainerCreating   0          34s
activator-5c48bb4df9-hvtkg                               1/1     Running             0          38s
activator-7f86fb77f8-ths68                               0/1     Terminating         0          24m
autoscaler-85b4ddb94b-cz86d                              1/1     Running             0          37s
autoscaler-hpa-79557d5979-2f2q2                          0/1     ContainerCreating   0          35s
autoscaler-hpa-cf56d8bcc-5f8nk                           1/1     Running             0          24m
controller-575457d5c-rs6nb                               1/1     Running             0          37s
domainmapping-webhook-859df874cb-x7gsd                   0/1     Terminating         0          24m
net-kourier-controller-76d9448d7b-54lxn                  1/1     Running             0          22m
net-kourier-controller-776c46b965-fns6x                  0/1     ContainerCreating   0          34s
storage-version-migration-serving-serving-1.11.0-sdcv6   0/1     ContainerCreating   0          35s
webhook-6859dd7cbf-b9td5                                 0/1     ContainerCreating   0          36s
webhook-74b6f5cf75-w8gpj                                 1/1     Running             0          24m


$ kubectl get po -n knative-serving
NAME                                                     READY   STATUS        RESTARTS   AGE
3scale-kourier-gateway-5dfb69fb86-dtb5v                  1/1     Terminating   0          24m
3scale-kourier-gateway-77755d86dc-hkmh2                  1/1     Running       0          110s
activator-5c48bb4df9-hvtkg                               1/1     Running       0          114s
autoscaler-85b4ddb94b-cz86d                              1/1     Running       0          113s
autoscaler-hpa-79557d5979-2f2q2                          1/1     Running       0          111s
controller-575457d5c-rs6nb                               1/1     Running       0          113s
net-kourier-controller-776c46b965-fns6x                  1/1     Running       0          110s
storage-version-migration-serving-serving-1.11.0-sdcv6   0/1     Completed     0          111s
webhook-6859dd7cbf-b9td5                                 1/1     Running       0          112s

[dprotaso]

Ok awesome thanks for checking.