Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up certmanager conformance tests #15266

Closed
skonto opened this issue May 28, 2024 · 1 comment · Fixed by knative/infra#447 or #15261
Closed

Clean up certmanager conformance tests #15266

skonto opened this issue May 28, 2024 · 1 comment · Fixed by knative/infra#447 or #15261

Comments

@skonto
Copy link
Contributor

skonto commented May 28, 2024

What version of Knative?

1.14

Expected Behavior

Certmanager conformance tests should be removed as they are tested already as part of the regular
Serving tests and also they simply test the secret creation for a certificate request, they are not end-to-end tests.

Actual Behavior

Tests should be removed and all signers should be tested along with the other Serving tests

Steps to Reproduce the Problem

n/A

@skonto skonto added the kind/bug Categorizes issue or PR as related to a bug. label May 28, 2024
@skonto
Copy link
Contributor Author

skonto commented May 28, 2024

I am working on this here: #15261
I will remove the tests from the infra repo too.

@skonto skonto removed the kind/bug Categorizes issue or PR as related to a bug. label May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant