Early bobs not working in 0.6.0

[kneasle]

This happens if the first call of a touch happens in rounds, and I'm pretty sure this is because in RR the RowGenerator is not created until the method starts, which means it doesn't get to see any incoming calls.

[centreboard]

Looks like the generator assigned on Look To, after which calls should be passed to it

wheatley/wheatley/bot.py

Lines 182 to 183 in 1bbdc8e

	self.row_generator = self.next_row_generator or self.row_generator
	self.next_row_generator = None

But we reset the generator's state as the method starts

wheatley/wheatley/bot.py

Line 319 in 1bbdc8e

self.row_generator.reset()

wheatley/wheatley/row_generation/row_generator.py

Lines 26 to 33 in 1bbdc8e

	def reset(self) -> None:
	""" Reset the row generator. """
	self.logger.debug("Reset")
	self._has_bob = False
	self._has_single = False
	self._index = 0
	self._row = self.rounds()

The reset could be earlier, e.g. on Look To. I don't think it would have any other impact

[kneasle]

Oooh wait so does that mean that this is a 0.6.0 issue?

The reset could be earlier, e.g. on Look To. I don't think it would have any other impact

Wouldn't the same problem happen if people start again without stopping the touch (i.e. just go again whilst still in rounds).

[centreboard]

Good point, there would need to be a reset when Wheatley starts ringing rounds after That's all (or a future call of Rounds)

[kneasle]

Yeah although if we're modelling Wheatley's behaviour as a state machine, then we should reset every time Wheatley enters the 'ringing rounds' state.