Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom calls don't work with the 'special' method names #87

Open
kneasle opened this issue Aug 26, 2020 · 2 comments
Open

Custom calls don't work with the 'special' method names #87

kneasle opened this issue Aug 26, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@kneasle
Copy link
Owner

kneasle commented Aug 26, 2020

This means you can't ring things like anti-April-Day (Grandsire with Plain Bob calls).

A solution could be that we turn generator_from_special_title into a function that takes a method title and optional calls and always returns a RowGenerator. We should also remove the defaults of 14/1234 calls, and have the generator_from_special_title replacement decide on the custom calls.

@kneasle kneasle added the bug Something isn't working label Aug 26, 2020
@centreboard
Copy link
Collaborator

anti-April-Day

I can't actually find what that should be called http://www.cambridgeringing.info/Methods/Doubles/METHVAR.htm
But your suggestions sound a sensible way to go

@kneasle
Copy link
Owner Author

kneasle commented Sep 9, 2020

I think that this issue will be largely offset if #96 gets resolved - Bob Wallis' website has its own method name overrides and custom calls and we can just use them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants