feat: introduce knock init and knock.json file #653
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjbell
force-pushed
the
cjbell-kno-10385-cli-introduce-knock-init-and-knockjson-file
branch
3 times, most recently
from
b80d410 to
6ef4296
Compare
MikeCarbone
reviewed
Nov 3, 2025
MikeCarbone
approved these changes
Nov 3, 2025
Contributor
MikeCarbone
left a comment
MikeCarbone
left a comment
There was a problem hiding this comment.
Small comment but looks good otherwise, lfg!
mattmikolay
reviewed
Nov 3, 2025
mattmikolay
reviewed
Nov 3, 2025
thomaswhyyou
reviewed
Nov 3, 2025
Contributor
thomaswhyyou
left a comment
thomaswhyyou
left a comment
There was a problem hiding this comment.
A few small things, but it's looking good - thanks for taking a stab at this!
cjbell
force-pushed
the
cjbell-kno-10385-cli-introduce-knock-init-and-knockjson-file
branch
2 times, most recently
from
99af9b0 to
2e785b9
Compare
cjbell
force-pushed
the
cjbell-kno-10385-cli-introduce-knock-init-and-knockjson-file
branch
from
2e785b9 to
75788f4
Compare
thomaswhyyou
reviewed
Nov 5, 2025
Contributor
thomaswhyyou
left a comment
thomaswhyyou
left a comment
There was a problem hiding this comment.
Looking really great- left a couple follow up comments/questions but looks pretty close to ship.
cjbell
deleted the
cjbell-kno-10385-cli-introduce-knock-init-and-knockjson-file
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds project configuration support to the Knock CLI through a
knock.jsonfile. The implementation includes:initcommand that creates aknock.jsonconfiguration file in the current directoryknockDir)This change improves the developer experience by eliminating the need to specify the
--knock-dirflag with every command, allowing for a more streamlined workflow when working with Knock resources.Tasks
KNO-10385