-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support binance portfolio margin 1.5 #4769
Comments
any comments? thoughts? |
@makarid any thoughts? think i will add 2 flags |
As Binance has separate base URL's (i.e. https://papi.binance.com) i controlled it by setting exchange specific parameters. |
arggh tests failing on kraken, will try to take a look and fix them up. |
Hi, binance's new portfolio margin 1.5 (offsetting spot and perp positions) requires new end points ((i.e https://papi.binance.com) to place, cancel orders etc etc (https://binance-docs.github.io/apidocs/pm/en/#change-log).
Unless there are any objections I am proposing I add the following methods to
org.knowm.xchange.binance.service.BinanceTradeServiceRaw
and then addUSE_PORTFOLIO_MARGIN
order flag toorg.knowm.xchange.binance.dto.trade.BinanceOrderFlags
to control the switching to the portfolio margin endpoints (i.e https://papi.binance.com) by using theUSE_PORTFOLIO_MARGIN
order flag inorg.knowm.xchange.binance.service.BinanceTradeService
org.knowm.xchange.binance.service.BinanceTradeServiceRaw
Unless that are any comments or objections I will assume that everyone is ok with me continuing with this approach.
The text was updated successfully, but these errors were encountered: