You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Such issues don't happen on binace xchange implementation, they both seem to use the same decorator pattern, so wondering if there is something else here is not thread safe. Pointers welcomed on where the threading issue might be! Making the public String digestParams(RestInvocation restInvocation) synchronised seems a bit overkill public synchronized String digestParams(RestInvocation restInvocation)
Think the issue might be with the mac object, looking over javax.crypto.Mac I am not sure it is thread safe, so wonder if we need a new mac each time akin to this in org.knowm.xchange.service.BaseParamsDigest
public Mac getMac() {
return mac;
}
to
public Mac getMac() {
try {
return (Mac) mac.clone();
} catch (Error | Exception e) {
throw new IllegalStateException(e);
}
I noticed a lot of okx requests get rejected with invaild sign when submitting multiple requests at same time.
Such issues don't happen on binace xchange implementation, they both seem to use the same decorator pattern, so wondering if there is something else here is not thread safe. Pointers welcomed on where the threading issue might be! Making the
public String digestParams(RestInvocation restInvocation)
synchronised seems a bit overkillpublic synchronized String digestParams(RestInvocation restInvocation)
Binance
The text was updated successfully, but these errors were encountered: