diff --git a/jsapp/js/account/accountSettings.scss b/jsapp/js/account/accountSettings.scss index c79fef751a..f22ec9e19f 100644 --- a/jsapp/js/account/accountSettings.scss +++ b/jsapp/js/account/accountSettings.scss @@ -79,10 +79,6 @@ .account-settings-save:last-child { margin-right: sizes.$x50; } - - .account-settings-close { - padding: 0 12px; - } } .form-modal__item { diff --git a/jsapp/js/account/changePasswordRoute.component.tsx b/jsapp/js/account/changePasswordRoute.component.tsx index 7122b1c98b..8cde65feb1 100644 --- a/jsapp/js/account/changePasswordRoute.component.tsx +++ b/jsapp/js/account/changePasswordRoute.component.tsx @@ -9,6 +9,7 @@ import type {WithRouterProps} from 'jsapp/js/router/legacy'; import './accountSettings.scss'; import styles from './changePasswordRoute.module.scss'; import UpdatePasswordForm from './security/password/updatePasswordForm.component'; +import Button from 'js/components/common/button'; bem.AccountSettings = makeBem(null, 'account-settings'); bem.AccountSettings__left = makeBem(bem.AccountSettings, 'left'); @@ -33,12 +34,13 @@ const ChangePasswordRoute = class ChangePassword extends React.Component - + /> diff --git a/jsapp/js/bemComponents.ts b/jsapp/js/bemComponents.ts index 4a83f0bd37..dc1045a95d 100644 --- a/jsapp/js/bemComponents.ts +++ b/jsapp/js/bemComponents.ts @@ -6,17 +6,6 @@ import bem, {makeBem} from 'js/bem'; -// DEPRECATED: please don't use this component. From now on, we will only use -// the `Button` component (from `js/components/common/button`) as it covers -// all possible cases. -bem.Button = makeBem(null, 'mdl-button', 'button'); -bem.KoboButton = makeBem(null, 'kobo-button', 'button'); -bem.KoboLightButton = makeBem(null, 'kobo-light-button', 'button'); -bem.KoboTextButton = makeBem(null, 'kobo-text-button', 'button'); -// END DEPRECATED - -bem.KoboLightBadge = makeBem(null, 'kobo-light-badge', 'span'); - bem.KoboSelect = makeBem(null, 'kobo-select'); bem.KoboSelect__wrapper = makeBem(bem.KoboSelect, 'wrapper'); bem.KoboSelect__label = makeBem(bem.KoboSelect, 'label', 'span'); @@ -31,13 +20,10 @@ bem.EmptyContent = makeBem(null, 'empty-content', 'section'); bem.EmptyContent__icon = makeBem(bem.EmptyContent, 'icon', 'i'); bem.EmptyContent__title = makeBem(bem.EmptyContent, 'title', 'h1'); bem.EmptyContent__message = makeBem(bem.EmptyContent, 'message', 'p'); -bem.EmptyContent__button = makeBem(bem.EmptyContent, 'button', 'button'); bem.ServiceRow = makeBem(null, 'service-row'); bem.ServiceRow__column = makeBem(bem.ServiceRow, 'column'); -bem.ServiceRow__actionButton = makeBem(bem.ServiceRow, 'action-button', 'button'); bem.ServiceRow__linkOverlay = makeBem(bem.ServiceRow, 'link-overlay', 'a'); -bem.ServiceRowButton = makeBem(null, 'service-row-button', 'button'); bem.FormBuilder = makeBem(null, 'form-builder'); bem.FormBuilder__contents = makeBem(bem.FormBuilder, 'contents'); @@ -55,8 +41,6 @@ bem.FormBuilderHeader = makeBem(null, 'form-builder-header'); bem.FormBuilderHeader__row = makeBem(bem.FormBuilderHeader, 'row'); bem.FormBuilderHeader__cell = makeBem(bem.FormBuilderHeader, 'cell'); bem.FormBuilderHeader__item = makeBem(bem.FormBuilderHeader, 'item', 'span'); -bem.FormBuilderHeader__button = makeBem(bem.FormBuilderHeader, 'button', 'button'); -bem.FormBuilderHeader__close = makeBem(bem.FormBuilderHeader, 'close', 'button'); bem.FormMedia = makeBem(null, 'form-media'); bem.FormMedia__title = makeBem(bem.FormMedia, 'title'); @@ -101,16 +85,6 @@ bem.TableMeta__bulkOptions = makeBem(bem.TableMeta, 'bulk-options'); bem.CollectionsWrapper = makeBem(null, 'collections-wrapper'); -bem.CollectionNav = makeBem(null, 'collection-nav'); -bem.CollectionNav__search = makeBem(bem.CollectionNav, 'search'); -bem.CollectionNav__searchcriteria = makeBem(bem.CollectionNav, 'searchcriteria', 'ul'); -bem.CollectionNav__searchcriterion = makeBem(bem.CollectionNav, 'searchcriterion', 'li'); -bem.CollectionNav__actions = makeBem(bem.CollectionNav, 'actions'); -bem.CollectionNav__button = makeBem(bem.CollectionNav, 'button', 'button'); -bem.CollectionNav__link = makeBem(bem.CollectionNav, 'link', 'a'); -bem.CollectionNav__searchcancel = makeBem(bem.CollectionNav, 'searchcancel', 'i'); -bem.CollectionNav__searchicon = makeBem(bem.CollectionNav, 'searchicon', 'i'); - bem.FormView = makeBem(null, 'form-view'); // used in header.es6 bem.FormView__title = makeBem(bem.FormView, 'title'); @@ -123,7 +97,6 @@ bem.FormView__sidetabs = makeBem(bem.FormView, 'sidetabs'); bem.FormView__label = makeBem(bem.FormView, 'label'); bem.FormView__group = makeBem(bem.FormView, 'group'); bem.FormView__item = makeBem(bem.FormView, 'item'); -bem.FormView__iconButton = makeBem(bem.FormView, 'icon-button', 'button'); bem.FormView__row = makeBem(bem.FormView, 'row'); bem.FormView__cell = makeBem(bem.FormView, 'cell'); @@ -131,9 +104,6 @@ bem.FormView__cellLabel = makeBem(bem.FormView, 'cell-label'); bem.FormView__column = makeBem(bem.FormView, 'column'); bem.FormView__banner = makeBem(bem.FormView, 'banner'); -bem.FormView__link = makeBem(bem.FormView, 'link', 'a'); -bem.FormView__secondaryButtons = makeBem(bem.FormView, 'secondaryButtons'); -bem.FormView__secondaryButton = makeBem(bem.FormView, 'secondaryButton', 'button'); bem.FormView__reportButtons = makeBem(bem.FormView, 'reportButtons'); bem.FormView__form = makeBem(bem.FormView, 'form', 'form'); @@ -147,7 +117,6 @@ bem.ReportView__item = makeBem(bem.ReportView, 'item'); bem.ReportView__itemHeading = makeBem(bem.ReportView, 'itemHeading'); bem.ReportView__headingMeta = makeBem(bem.ReportView, 'headingMeta'); bem.ReportView__itemContent = makeBem(bem.ReportView, 'itemContent'); -bem.ReportView__headingButton = makeBem(bem.ReportView, 'headingButton', 'button'); bem.ReportView__chart = makeBem(bem.ReportView, 'chart'); bem.GraphSettings = makeBem(null, 'graph-settings'); @@ -236,7 +205,6 @@ bem.Breadcrumbs__divider = makeBem(bem.Breadcrumbs, 'divider', 'i'); bem.AssetInfoBox = makeBem(null, 'asset-info-box'); bem.AssetInfoBox__column = makeBem(bem.AssetInfoBox, 'column'); bem.AssetInfoBox__cell = makeBem(bem.AssetInfoBox, 'cell'); -bem.AssetInfoBox__toggle = makeBem(bem.AssetInfoBox, 'toggle', 'button'); bem.PrintOnly = makeBem(null, 'print-only'); @@ -245,13 +213,11 @@ bem.ProjectDownloads__advancedView = makeBem(bem.ProjectDownloads, 'advanced-vie bem.ProjectDownloads__column = makeBem(bem.ProjectDownloads, 'column'); bem.ProjectDownloads__columnRow = makeBem(bem.ProjectDownloads, 'column-row'); bem.ProjectDownloads__title = makeBem(bem.ProjectDownloads, 'title', 'span'); -bem.ProjectDownloads__textButton = makeBem(bem.ProjectDownloads, 'text-button', 'button'); bem.ProjectDownloads__selectorRow = makeBem(bem.ProjectDownloads, 'selector-row'); bem.ProjectDownloads__anonymousRow = makeBem(bem.ProjectDownloads, 'anonymous-row'); bem.ProjectDownloads__legacyIframeWrapper = makeBem(bem.ProjectDownloads, 'legacy-iframe-wrapper'); bem.ProjectDownloads__submitRow = makeBem(bem.ProjectDownloads, 'submit-row', 'footer'); bem.ProjectDownloads__exportsSelector = makeBem(bem.ProjectDownloads, 'exports-selector'); -bem.ProjectDownloads__deleteSettingsButton = makeBem(bem.ProjectDownloads, 'delete-settings-button', 'button'); bem.ProjectDownloads__exportsCreator = makeBem(bem.ProjectDownloads, 'exports-creator'); bem.BackgroundAudioPlayer = makeBem(null, 'background-audio-player'); diff --git a/jsapp/js/components/RESTServices.scss b/jsapp/js/components/RESTServices.scss index 56e18b904b..33de8a3cae 100644 --- a/jsapp/js/components/RESTServices.scss +++ b/jsapp/js/components/RESTServices.scss @@ -53,14 +53,6 @@ } .rest-services-list__header-right {float: right;} - - .rest-services-list__header-back-button { - @extend .mdl-button, .mdl-button--icon; - - i { - vertical-align: middle; - } - } } // custom styles for RESTServicesForm diff --git a/jsapp/js/components/RESTServices/RESTServiceLogs.es6 b/jsapp/js/components/RESTServices/RESTServiceLogs.es6 index 7c5133198d..de8f6b04f0 100644 --- a/jsapp/js/components/RESTServices/RESTServiceLogs.es6 +++ b/jsapp/js/components/RESTServices/RESTServiceLogs.es6 @@ -15,6 +15,7 @@ import { HOOK_LOG_STATUSES, MODAL_TYPES } from '../../constants'; +import Button from 'js/components/common/button'; export default class RESTServiceLogs extends React.Component { constructor(props){ @@ -203,13 +204,16 @@ export default class RESTServiceLogs extends React.Component { renderHeader() { return (
- - - {t('Back to REST Services')} - + + + - - + + + + /> {userCanSeeEditIcon && userHasPermForSubmission( @@ -587,15 +590,17 @@ export class DataTable extends React.Component { this.props.asset, row.original ) && ( - + /> )} ), @@ -1530,23 +1535,25 @@ export class DataTable extends React.Component { {this.renderBulkSelectUI()} - - - - - + + + + } + /> } - {selectedCount > 1 && :} - {Object.keys(this.props.selectedRows).length > 0 && - + + } + > {(userCan(PERMISSIONS_CODENAMES.validate_submissions, this.props.asset) || userCanPartially(PERMISSIONS_CODENAMES.validate_submissions, this.props.asset)) && VALIDATION_STATUS_OPTIONS.map((item, n) => { return ( @@ -225,24 +249,28 @@ class TableBulkOptions extends React.Component { } {Object.keys(this.props.selectedRows).length > 0 && this.props.asset.deployment__active && (userCan(PERMISSIONS_CODENAMES.change_submissions, this.props.asset) || userCanPartially(PERMISSIONS_CODENAMES.change_submissions, this.props.asset)) && - - - {t('Edit')} - + isDisabled={this.props.selectedAllPages && isSelectAllAvailable} + startIcon='edit' + label={t('Edit')} + className='table-meta__additional-text' + /> } {Object.keys(this.props.selectedRows).length > 0 && (userCan(PERMISSIONS_CODENAMES.delete_submissions, this.props.asset) || userCanPartially(PERMISSIONS_CODENAMES.delete_submissions, this.props.asset)) && - - - {t('Delete')} - + startIcon='trash' + label={t('Delete')} + className='table-meta__additional-text' + /> } ); diff --git a/jsapp/js/components/submissions/tableSettings.es6 b/jsapp/js/components/submissions/tableSettings.es6 index bdf6aad8d2..c8923b8d9c 100644 --- a/jsapp/js/components/submissions/tableSettings.es6 +++ b/jsapp/js/components/submissions/tableSettings.es6 @@ -8,6 +8,7 @@ import {notify} from 'utils'; import {DATA_TABLE_SETTINGS} from 'js/components/submissions/tableConstants'; import {userCan} from 'js/components/permissions/utils'; import tableStore from 'js/components/submissions/tableStore'; +import Button from 'js/components/common/button'; import './tableSettings.scss'; /** @@ -117,14 +118,22 @@ class TableSettings extends React.Component { {userCan('change_asset', this.props.asset) && - - {t('Reset')} - +