Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn when unnamed groups are uploaded via XLSForm #3075

Open
jnm opened this issue Mar 16, 2021 · 2 comments
Open

Warn when unnamed groups are uploaded via XLSForm #3075

jnm opened this issue Mar 16, 2021 · 2 comments
Labels
bug Things broken and not working as expected check-if-stale

Comments

@jnm
Copy link
Member

jnm commented Mar 16, 2021

Edit: maybe "reject" is a better approach than "warn".

Especially unnamed, unlabeled groups. These will have newly auto-generated names assigned each time the XLSForm is re-uploaded. kobotoolbox/formpack#206 can be triggered by this, but even when that is fixed, groups whose names change with every version are going to create a mess in the exports (likely new columns for each group [1] [2] [3]).

Internal discussion: https://chat.kobotoolbox.org/#narrow/stream/4-KoBo-Dev/topic/Export.20failure.20on.20multiple.20versions/near/21509

How to reproduce:

  1. create an XLSForm with a repeating group that has both no name and no label unnamed and unlabeled repeat.xlsx
  2. upload it to KPI
  3. look at the form json; see (e.g.) begin_repeat_oqAkea1ft
  4. upload the same XLSForm again
  5. refresh the json
  6. see (e.g.) begin_repeat_B8cPyAGB7; notice it's different than the name seen in (3)

Workaround for when this happens (or even when people deliberately change group names): https://community.kobotoolbox.org/t/export-failed-error/13957. I'm unsure whether the workaround can be used in all cases.

@tinok
Copy link
Member

tinok commented Mar 17, 2021

👍
I feel that if someone uploads an incorrect XLSForm we should in the future reject it (with useful feedback), as we do for many kinds of errors; but importing an invalid form and silently adding / updating names goes in the area of editing someone's form.

@Kalyan-Lama
Copy link

@jnm, maybe this community post and the verification I made should be helpful:

https://community.kobotoolbox.org/t/export-data-failed/17583/14

@JacquelineMorrissette JacquelineMorrissette added bug Things broken and not working as expected check-if-stale labels Sep 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Things broken and not working as expected check-if-stale
Projects
None yet
Development

No branches or pull requests

4 participants