Merge pull request #68 from r3mv/master

kochedykov · web-flow · commit 2bbd962c4bc2 · 2023-11-13T13:35:45.000+05:00
CheckRegister value does truncate negative values
diff --git a/src/com/intelligt/modbus/jlibmodbus/Modbus.java b/src/com/intelligt/modbus/jlibmodbus/Modbus.java
@@ -290,7 +290,7 @@ static public boolean checkEndAddress(int value) {
      * @return "true" if register value is correct, else "false".
      */
     static public boolean checkRegisterValue(int value) {
-        return checkRange(value, 0, Modbus.MAX_REGISTER_VALUE);
+        return checkRange((short)value, Short.MIN_VALUE, Short.MAX_VALUE);
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -290,7 +290,7 @@ static public boolean checkEndAddress(int value) {`
`290`	`290`	`* @return "true" if register value is correct, else "false".`
`291`	`291`	`*/`
`292`	`292`	`static public boolean checkRegisterValue(int value) {`
`293`		`- return checkRange(value, 0, Modbus.MAX_REGISTER_VALUE);`
	`293`	`+ return checkRange((short)value, Short.MIN_VALUE, Short.MAX_VALUE);`
`294`	`294`	`}`
`295`	`295`
`296`	`296`	`/**`