Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflict of nanoflann namespace issue #38

Closed
LimHyungTae opened this issue Apr 26, 2024 · 2 comments
Closed

Conflict of nanoflann namespace issue #38

LimHyungTae opened this issue Apr 26, 2024 · 2 comments

Comments

@LimHyungTae
Copy link

Hello Koide, thanks for sharing this nice stuff.

I tried to include this repository, and I found that once the repository already contains nanoflann.hpp, then two nanoflann.hpp brings namespace conflict error.

Of course, it's very easy to resolve by manually changing the workspace name in the own package, but maybe we have to change the namespace of nanoflann.hpp in this repository for better usability (e.g., namespace koide_nanoflann or something)

Thanks!

@koide3
Copy link
Owner

koide3 commented Apr 27, 2024

Thanks for reporting the issue. I recently re-implemented KdTree, and I'm considering to replace nanoflann with the new KdTree. It would resolve the conflict and bring (very slight) speed improvement.

@koide3
Copy link
Owner

koide3 commented May 1, 2024

I replaced nanoflann with a new KdTree implementation in this PR #42 that would resolve the conflict. I'll merge it once some errors on windows are fixed.

@koide3 koide3 closed this as completed May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants