diff --git a/DESCRIPTION b/DESCRIPTION index 40d2c3f..ce5cbec 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -4,7 +4,7 @@ Version: 1.0.0 Authors@R: c(person(given = "Michal", family = "Kolesár", - role = c("aut", "cre"), + role = c("aut", "cre", "cph"), email = "kolesarmi@googlemail.com", comment = c(ORCID = "0000-0002-2482-7796")), person(given= "Tim", @@ -13,7 +13,9 @@ Authors@R: email = "timothy.armstrong@usc.edu")) Description: Honest and nearly-optimal confidence intervals in fuzzy and sharp regression discontinuity designs and for inference at a point based on local - linear regression. Supports covariates, clustering, and weighting. + linear regression. The implementation is based on Armstrong and Kolesár (2018) + , and Kolesár and Rothe (2018) + . Supports covariates, clustering, and weighting. Depends: R (>= 4.3.0) License: GPL-3 Encoding: UTF-8 diff --git a/R/RDHonest.R b/R/RDHonest.R index cc6eafe..4c6af09 100644 --- a/R/RDHonest.R +++ b/R/RDHonest.R @@ -153,7 +153,7 @@ #' #' \cite{Timothy B. Armstrong and Michal Kolesár. Simple and honest confidence #' intervals in nonparametric regression. Quantitative Economics, 11(1):1–39, -#' January 2020. \doi{10.3982/QE1199}} +#' January 2020. \url{https://onlinelibrary.wiley.com/doi/full/10.3982/QE1199}} #' #' \cite{Michal Kolesár and Christoph Rothe. Inference in regression #' discontinuity designs with a discrete running variable. American Economic diff --git a/R/documentation.R b/R/documentation.R index 22213dc..c7c8596 100644 --- a/R/documentation.R +++ b/R/documentation.R @@ -80,7 +80,7 @@ #' \item{margin}{Democratic margin of victory} #' } #' @source Mostly Harmless Econometrics data archive, -#' \url{https://economics.mit.edu/faculty/angrist/data1/mhe} +#' \url{https://economics.mit.edu/people/faculty/josh-angrist/mhe-data-archive} #' @references{ #' #' \cite{David S. Lee. Randomized experiments from non-random selection in U.S. diff --git a/README.md b/README.md index 7f963b3..369f5a8 100644 --- a/README.md +++ b/README.md @@ -1,4 +1,4 @@ -[![R-CMD-check](https://github.com/kolesarm/RDHonest/workflows/R-CMD-check/badge.svg)](https://github.com/kolesarm/RDHonest/actions) [![Coverage status](https://codecov.io/gh/kolesarm/RDHonest/branch/master/graph/badge.svg)](https://codecov.io/github/kolesarm/RDHonest?branch=master) +[![R-CMD-check](https://github.com/kolesarm/RDHonest/workflows/R-CMD-check/badge.svg)](https://github.com/kolesarm/RDHonest/actions) [![Coverage status](https://codecov.io/gh/kolesarm/RDHonest/branch/master/graph/badge.svg)](https://app.codecov.io/github/kolesarm/RDHonest?branch=master) # RDHonest diff --git a/cran-comments.md b/cran-comments.md new file mode 100644 index 0000000..4885f3e --- /dev/null +++ b/cran-comments.md @@ -0,0 +1,31 @@ +## Test environments +* local Debian 12 (bookworm) install, R 4.3.1 +* Github actions + - macOS 12.7.3, R 4.3.3 + - Windows Server 2022, R 4.3.3 + - Ubuntu 22.04.4 LTS, R 4.3.3 + - Ubuntu 20.04.4 LTS, R-devel + + +* win-builder, R-devel and R-release +* macbuilder macOS 13.3.1 (22E261) R4.3.0 Patched (2023-05-18 r84451) +* Rhub + - Ubuntu Linux 20.04.1 LTS, R-release, GCC + - Debian Linux, R-devel, GCC, no long double + +## R CMD check results +There were no ERRORs or WARNINGs. +There was 1 NOTE: + + Maintainer: ‘Michal Kolesár ’ + + New submission + +Possibly misspelled words in DESCRIPTION: + covariates (16:33) + +THe misspelled word is correct, it refers to independent variables (covariates) +in a regression. + +## Downstream dependencies +There are currently no downstream dependencies for this package diff --git a/doc/RDHonest.pdf b/doc/RDHonest.pdf index ae94a95..849a3f8 100644 Binary files a/doc/RDHonest.pdf and b/doc/RDHonest.pdf differ diff --git a/doc/manual.pdf b/doc/manual.pdf index adbf0f4..f82bb1b 100644 Binary files a/doc/manual.pdf and b/doc/manual.pdf differ diff --git a/man/RDHonest.Rd b/man/RDHonest.Rd index 943d782..7acccd0 100644 --- a/man/RDHonest.Rd +++ b/man/RDHonest.Rd @@ -236,7 +236,7 @@ of regression models. Econometrica, 86(2):655–683, March 2018. \cite{Timothy B. Armstrong and Michal Kolesár. Simple and honest confidence intervals in nonparametric regression. Quantitative Economics, 11(1):1–39, -January 2020. \doi{10.3982/QE1199}} +January 2020. \url{https://onlinelibrary.wiley.com/doi/full/10.3982/QE1199}} \cite{Michal Kolesár and Christoph Rothe. Inference in regression discontinuity designs with a discrete running variable. American Economic diff --git a/man/lee08.Rd b/man/lee08.Rd index eb42e13..fe646f8 100644 --- a/man/lee08.Rd +++ b/man/lee08.Rd @@ -13,7 +13,7 @@ A data frame with 6,558 rows and 2 variables: } \source{ Mostly Harmless Econometrics data archive, -\url{https://economics.mit.edu/faculty/angrist/data1/mhe} +\url{https://economics.mit.edu/people/faculty/josh-angrist/mhe-data-archive} } \usage{ lee08 diff --git a/vignettes/np-testing-library.bib b/vignettes/np-testing-library.bib index 13400f4..e4b5967 100644 --- a/vignettes/np-testing-library.bib +++ b/vignettes/np-testing-library.bib @@ -149,7 +149,6 @@ @article{ArKo20 title = {Simple and Honest Confidence Intervals in Nonparametric Regression}, journal = {Quantitative Economics}, year = 2020, -doi = {10.3982/QE1199}, volume = 11, number = 1, pages = {1--39},