Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure we capture file modtime in all checkups in flares #1949

Closed
2 tasks
RebeccaMahany opened this issue Nov 11, 2024 · 0 comments · Fixed by #1950
Closed
2 tasks

Ensure we capture file modtime in all checkups in flares #1949

RebeccaMahany opened this issue Nov 11, 2024 · 0 comments · Fixed by #1950

Comments

@RebeccaMahany
Copy link
Contributor

I noticed a lot of files in our flares come up as having a date modified of November 30, 1979 -- i.e. we don't set metadata on these files before writing them. It would be useful if we could set this metadata on these files so that we can see that info at a glance.

We do have a utility function addFileToZip, which writes out a .flaremeta file containing modtime, create time, and mode -- this doesn't let us see the information at a glance, but does make sure we capture it. We should audit all of our checkups and make sure we are always using this function when writing files to zip. (The one I noticed isn't using addFileToZip is Logs, but there may be others.)

I think we also should be able to set this data on the file in the zip itself (via the FileHeader).

  • Audit all checkups that run for flares and make sure we use addFileToZip for any checkups that write a file from disk to the zip file
  • Update addFileToZip to set metadata (modtime, create time, mode) on the file in the zip
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant