Newitcv #84
Merged
Newitcv #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changed following Dr.Lin's modification
now we RIR_primary, RIR_supplemental, RIR_perc, fragility_primary, fragility_supplemental
align with Dr.Lin's change
* update the eff_thr for linear and output update the eff_thr for linear and corresponding output. together with some other slight updates on the output. needs verification. * fix an output condition * revise test_sensitivity revise for linear case for eff_thr and nu * fix the bug for eff_thr the problem is that mp and signITCV should be determined at the correlation scale * fix the bug for RIR verification * update the definitions of signsuppression and eff_thr * Update test_sensitivity.R Edit the line break for the updated eff_thr and nu statements * change signsuppression to far_bound * update the help info for replace argument * update some help info * update error message and cop * update test for cop * Update test_sensitivity.R edits for line break * update test_sensitivity based on errors from the big loop 1. fix cases when RIR is impossible but need to calculate ITCV 2. fix mp when far_bound == 1 * add an error message for critical_r > 1 * Update test_sensitivity.R small edits for consistent line break * Update help info for pkonfound with regards to value section (raw_output) * improve error message in case of small cells * edits for return describe pkonfound * update help file * revise for special case when perc_to_change and recase is NA make sure it is still possible to calculate IT --------- Co-authored-by: Jihoon_Choi <50298939+JihoonChoi26@users.noreply.github.com>
Add R2 in input variable list, and conditional reminder if R2 is NA
Add R2 as a input variable in output_print calling function
Edits stop message for partial input of unconditional ITCV
Edit on reminder of unconditional ITCV
jrosen48
reviewed
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.