Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create rules for bean handling annotations #137

Open
jmle opened this issue Oct 2, 2024 · 2 comments
Open

Create rules for bean handling annotations #137

jmle opened this issue Oct 2, 2024 · 2 comments
Labels
needs-kind Indicates an issue or PR lacks a `kind/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/backlog Higher priority than priority/awaiting-more-evidence. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. spring-migration/6 Label for Spring Migration path 5 -> 6 spring-migration/6.0 Label for Spring Migration path 5.x -> 6.0

Comments

@jmle
Copy link
Contributor

jmle commented Oct 2, 2024

According to the migration guide:

The JSR-330 based @Inject annotation is to be found in jakarta.inject now. The corresponding JSR-250 based annotations @PostConstruct and @PreDestroy are to be found in jakarta.annotation. For the time being, Spring keeps detecting their javax equivalents as well, covering common use in pre-compiled binaries.

Investigate and create rules if necessary.

In the rule description and message, try to be as verbose and clear as possible. Code examples are always welcome and useful. Feel free to use markdown syntax for these.

@jmle jmle added spring-migration/6 Label for Spring Migration path 5 -> 6 spring-migration/6.0 Label for Spring Migration path 5.x -> 6.0 labels Oct 2, 2024
@konveyor-ci-bot konveyor-ci-bot bot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Oct 2, 2024
@konveyor-ci-bot
Copy link

This issue is currently awaiting triage.
If contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.
The triage/accepted label can be added by org members.

@konveyor-ci-bot konveyor-ci-bot bot added the needs-kind Indicates an issue or PR lacks a `kind/foo` label and requires one. label Oct 2, 2024
@konveyor-ci-bot konveyor-ci-bot bot added the needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. label Oct 2, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in Planning Oct 2, 2024
@jmle jmle added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Oct 24, 2024
@konveyor-ci-bot konveyor-ci-bot bot removed the needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. label Oct 28, 2024
@jmle
Copy link
Contributor Author

jmle commented Nov 4, 2024

This is low hanging fruit, but it is covered by our javax to jakarta rules. Not sure if we really need to create a rule for this. Moving to priority/backlog.

@jmle jmle added priority/backlog Higher priority than priority/awaiting-more-evidence. and removed priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-kind Indicates an issue or PR lacks a `kind/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/backlog Higher priority than priority/awaiting-more-evidence. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. spring-migration/6 Label for Spring Migration path 5 -> 6 spring-migration/6.0 Label for Spring Migration path 5.x -> 6.0
Projects
Status: 🆕 New
Development

No branches or pull requests

1 participant