Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create rules for controller detection #152

Open
jmle opened this issue Oct 2, 2024 · 2 comments
Open

Create rules for controller detection #152

jmle opened this issue Oct 2, 2024 · 2 comments
Assignees
Labels
needs-kind Indicates an issue or PR lacks a `kind/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. spring-migration/6 Label for Spring Migration path 5 -> 6 spring-migration/6.0 Label for Spring Migration path 5.x -> 6.0

Comments

@jmle
Copy link
Contributor

jmle commented Oct 2, 2024

According to the migration guide:

Spring MVC and Spring WebFlux no longer detect controllers based solely on a type-level @RequestMapping annotation. That means interface-based AOP proxying for web controllers may no longer work. Please, enable class-based proxying for such controllers; otherwise the interface must also be annotated with @controller. See 22154.

Investigate and create rules if necessary.

In the rule description and message, try to be as verbose and clear as possible. Code examples are always welcome and useful. Feel free to use markdown syntax for these.

@jmle jmle added spring-migration/6 Label for Spring Migration path 5 -> 6 spring-migration/6.0 Label for Spring Migration path 5.x -> 6.0 labels Oct 2, 2024
@konveyor-ci-bot konveyor-ci-bot bot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Oct 2, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in Planning Oct 2, 2024
@konveyor-ci-bot
Copy link

This issue is currently awaiting triage.
If contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.
The triage/accepted label can be added by org members.

@konveyor-ci-bot konveyor-ci-bot bot added needs-kind Indicates an issue or PR lacks a `kind/foo` label and requires one. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. labels Oct 2, 2024
@jmle
Copy link
Contributor Author

jmle commented Oct 24, 2024

Usage of @RequestMapping at type level would make for a potential rule. See also https://docs.spring.io/spring-framework/reference/core/aop/proxying.html for information about proxying mechanisms.

@jmle jmle added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 29, 2024
@konveyor-ci-bot konveyor-ci-bot bot removed the needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. label Oct 29, 2024
@jmle jmle self-assigned this Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-kind Indicates an issue or PR lacks a `kind/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. spring-migration/6 Label for Spring Migration path 5 -> 6 spring-migration/6.0 Label for Spring Migration path 5.x -> 6.0
Projects
Status: 🏗 In progress
Development

No branches or pull requests

1 participant