🐛 application can only have one review #1693
Conversation
|
djzager
added
the
cherry-pick/release-0.3
| @@ -425,7 +425,7 @@ export const ApplicationDetailDrawer: React.FC< | |||
| </Tab> | |||
| <Tab | |||
| eventKey={TabKey.Reviews} | |||
| title={<TabTitleText>{t("terms.reviews")}</TabTitleText>} | |||
| title={<TabTitleText>{t("terms.review")}</TabTitleText>} | |||
There was a problem hiding this comment.
Should be reviews.
An application can have more than one review inherited from multiple archetypes
There was a problem hiding this comment.
Then what exactly was meant by the comment:
Scott Dickerson please see attached app_review_mta-7.0.0-50.png, I think the best would be to title the tab in application side drawer "Review" as suggested in the bug summary.
Thanks
Based on this comment. The bug is fixed and should have been closed.
There was a problem hiding this comment.
I keep reading and re-reading trying to understand what I'm missing. My apologies. These look like two comments in direct opposition to each other.
One says, I think the best would be to title the tab in the application side drawer "Review"... and the comment made on the line that changes it to "Review" is Should be **reviews**.
There was a problem hiding this comment.
Question for you here:
When an application has a review at the app level, we only show the app review in the drawer as expected / discussed.
Then when we discard the review for the app, we show the inherited archetype reviews.
Want to figure out a better way to represent this in the UI. Any ideas here? There is some desire to change the review tab to read reviews / review depending on which scenario we are in. Wondering your take on this. Thanks!
There was a problem hiding this comment.
@djzager You are so right! I confused myself...
I forgot that I asked to change the tab title to "Review" and the initial purpose of the bug
In bottom line, application can have one or more reviews, so Review/Reviews are both acceptable as the tab title :)
The original bug was to make the term "Review" in both application and archetype drawer side, so LGTM
Sorry about that.
There was a problem hiding this comment.
@ibolton336 I think Review or Reviews is appropriate. I learn more to 'Reviews' since applications and archetypes can have more than one review. But many applications might only have one 'Review' so review sits just fine as well, and if its more than one its no big deal.
If the majority are okay with 'Review', which that seems to be the case, I'm good with 'Review' as well.
Signed-off-by: David Zager <dzager@redhat.com>
djzager
force-pushed
the
review-reviews
branch
from
8983c73
to
6cf2867
Compare
https://issues.redhat.com/browse/MTA-1888 It appears that an application can only have a single review. So this changes the Tab title from `Reviews` -> `Review` and drops the redundant header inside. Signed-off-by: David Zager <dzager@redhat.com> Co-authored-by: Ian Bolton <ibolton@redhat.com> Signed-off-by: Cherry Picker <noreply@github.com>
https://issues.redhat.com/browse/MTA-1888 It appears that an application can only have a single review. So this changes the Tab title from `Reviews` -> `Review` and drops the redundant header inside. Signed-off-by: David Zager <dzager@redhat.com> Co-authored-by: Ian Bolton <ibolton@redhat.com> Signed-off-by: Cherry Picker <noreply@github.com> Signed-off-by: David Zager <dzager@redhat.com> Signed-off-by: Cherry Picker <noreply@github.com> Co-authored-by: David Zager <dzager@redhat.com> Co-authored-by: Ian Bolton <ibolton@redhat.com>
https://issues.redhat.com/browse/MTA-1888
It appears that an application can only have a single review. So this changes the Tab title from
Reviews->Reviewand drops the redundant header inside.