Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement/CI] Fix or remove the codecov step of the repo CI #1820

Closed
sjd78 opened this issue Apr 5, 2024 · 1 comment · Fixed by #2056
Closed

[Enhancement/CI] Fix or remove the codecov step of the repo CI #1820

sjd78 opened this issue Apr 5, 2024 · 1 comment · Fixed by #2056
Assignees
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/minor Lowest priority. Possibly useful, but not yet enough support to actually get it done. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@sjd78
Copy link
Member

sjd78 commented Apr 5, 2024

In the ci-repo.yaml workflow, the codecov action is used to upload test coverage info to Codecov service and have the report posted back to the PR. This process has not been working a quite some time, with the error often looking like this:

==> Uploader SHASUM verified (e3ea28a069fe174eb99ac2ffb523bfb55d5d29a7cfd93ef48cde12e9b552b492  codecov)
info - 2024-04-05 14:34:31,824 -- ci service found: github-actions
info - 2024-04-05 14:34:32,070 -- The PR is happening in a forked repo. Using tokenless upload.
info - 2024-04-05 14:34:32,227 -- Process Commit creating complete
error - 2024-04-05 14:34:32,227 -- Commit creating failed: {"detail":"Tokenless has reached GitHub rate limit. Please upload using a token: https://docs.codecov.com/docs/adding-the-codecov-token. Expected available in 67 seconds."}

There are 2 solutions:

  1. Remove the codecov action and stop using it all together.
  2. Setup a token for the uploads.

Option 2 would require:

  • getting a token for the project on codecov
  • storing the token as a secrete on the repo (only a person with admin privlidges on the repo can do this)
  • passing the secrete/token to the action in the workflow

Update 31-May-24: Other CI changes seems to have enabled the codecov plugin on PRs. However, it also looks like the reports on the PRs are based on reports submitted from the target branch (i.e. main). The codecov steps in the repo-level CI is disabled for normal merges. This probably should also change.

@konveyor-ci-bot konveyor-ci-bot bot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Apr 5, 2024
@konveyor-ci-bot
Copy link

This issue is currently awaiting triage.
If contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.
The triage/accepted label can be added by org members.

@konveyor-ci-bot konveyor-ci-bot bot added needs-kind Indicates an issue or PR lacks a `kind/foo` label and requires one. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. labels Apr 5, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in Planning Apr 5, 2024
@sjd78 sjd78 added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/minor Lowest priority. Possibly useful, but not yet enough support to actually get it done. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-kind Indicates an issue or PR lacks a `kind/foo` label and requires one. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. labels May 2, 2024
@sjd78 sjd78 moved this from 🆕 New to 📋 Backlog in Planning Jun 6, 2024
@sjd78 sjd78 moved this from 📋 Backlog to 🔖 Ready in Planning Jun 6, 2024
@sjd78 sjd78 self-assigned this Aug 20, 2024
sjd78 added a commit that referenced this issue Aug 22, 2024
  - Setup concurrency on the ci-repo.yml workflow so rapid updates to a PR
    will have old/pending CI runs just cancel (saving resources)

  - Allow the codecov action to upload on any run. This should allow the
    codecov reports on PRs be accurate based on the current commit on main
    (or PR target branch)

Fixes: #1820

Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
@github-project-automation github-project-automation bot moved this from 🔖 Ready to ✅ Done in Planning Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/minor Lowest priority. Possibly useful, but not yet enough support to actually get it done. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

1 participant