Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Cannot close "Repository type" filter chips #2094

Closed
1 task done
rszwajko opened this issue Sep 13, 2024 · 1 comment · Fixed by #2093
Closed
1 task done

[BUG] Cannot close "Repository type" filter chips #2094

rszwajko opened this issue Sep 13, 2024 · 1 comment · Fixed by #2093
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@rszwajko
Copy link
Collaborator

Is there an existing issue for this?

  • I have searched the existing issues

Konveyor version

0.5

Priority

Minor

Current Behavior

User is not able to close individually filter chips created via SelectFilterControl. The only option is to use "Clear all filters".

Expected Behavior

No response

How Reproducible

Always (Default)

Steps To Reproduce

  1. on Application inventory screen select "Repository type" filter
  2. choose an option i.e Git
  3. try to close created chip using "close" icon (small X)

Environment

No response

Anything else?

No response
@rszwajko rszwajko added kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 13, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in Planning Sep 13, 2024
@konveyor-ci-bot
Copy link

This issue is currently awaiting triage.
If contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.
The triage/accepted label can be added by org members.

@konveyor-ci-bot konveyor-ci-bot bot added the needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. label Sep 13, 2024
@rszwajko rszwajko mentioned this issue Sep 13, 2024
Merged
@sjd78 sjd78 closed this as completed in 7768bf6 Sep 13, 2024
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Planning Sep 13, 2024
Shevijacobson pushed a commit to Shevijacobson/tackle2-ui that referenced this issue Sep 18, 2024
@rszwajko @Shevijacobson
🐛 Fix closing filter chips created via SelectFilterControl (konveyor#…
c0ffc55 
…2093)

Resolves: konveyor#2094

Signed-off-by: Radoslaw Szwajkowski <rszwajko@redhat.com>
Shevijacobson pushed a commit to Shevijacobson/tackle2-ui that referenced this issue Sep 18, 2024
@rszwajko @Shevijacobson
🐛 Fix closing filter chips created via SelectFilterControl (konveyor#…
42453dd 
…2093)

Resolves: konveyor#2094

Signed-off-by: Radoslaw Szwajkowski <rszwajko@redhat.com>
Signed-off-by: Shevijacobson <shevijacob@gmail.com>
DvoraShechter1 pushed a commit to DvoraShechter1/tackle2-ui that referenced this issue Sep 19, 2024
@rszwajko @DvoraShechter1
🐛 Fix closing filter chips created via SelectFilterControl (konveyor#…
98a9723 
…2093)

Resolves: konveyor#2094

Signed-off-by: Radoslaw Szwajkowski <rszwajko@redhat.com>
DvoraShechter1 pushed a commit to DvoraShechter1/tackle2-ui that referenced this issue Oct 28, 2024
@rszwajko @DvoraShechter1
🐛 Fix closing filter chips created via SelectFilterControl (konveyor#…
46366af 
…2093)

Resolves: konveyor#2094

Signed-off-by: Radoslaw Szwajkowski <rszwajko@redhat.com>
sarinailinger pushed a commit to sarinailinger/tackle2-ui that referenced this issue Oct 30, 2024
@rszwajko @sarinailinger
🐛 Fix closing filter chips created via SelectFilterControl (konveyor#…
7258e2f 
…2093)

Resolves: konveyor#2094

Signed-off-by: Radoslaw Szwajkowski <rszwajko@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
Planning
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🐛 Fix closing filter chips created via SelectFilterControl rszwajko/tackle2-ui
1 participant
@rszwajko