Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Update stakeholder groups table to use ActionsColumn #2095

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

MiriSafra
Copy link
Contributor

@MiriSafra MiriSafra commented Sep 15, 2024

Addition ActionsColumn to Stakeholder groups table
Relates to #1318
UI tests PR: 1222

Copy link

codecov bot commented Sep 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.01%. Comparing base (b654645) to head (9b17c3a).
Report is 237 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2095      +/-   ##
==========================================
+ Coverage   39.20%   42.01%   +2.81%     
==========================================
  Files         146      175      +29     
  Lines        4857     5617     +760     
  Branches     1164     1340     +176     
==========================================
+ Hits         1904     2360     +456     
- Misses       2939     3241     +302     
- Partials       14       16       +2     
Flag Coverage Δ
client 42.01% <ø> (+2.81%) ⬆️
server ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MiriSafra MiriSafra changed the title change icons in S_G table sparkles: change icons in S_G table Sep 15, 2024
@MiriSafra MiriSafra changed the title sparkles: change icons in S_G table ✨ change icons in S_G table Sep 15, 2024
@MiriSafra MiriSafra marked this pull request as ready for review September 15, 2024 15:10
Copy link
Collaborator

@mguetta1 mguetta1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MiriSafra for the PR. Please see my comments

package-lock.json Outdated Show resolved Hide resolved
Copy link
Collaborator

@mguetta1 mguetta1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: MiriSafra <M0533175827@gmail.com>
@mguetta1
Copy link
Collaborator

mguetta1 commented Sep 17, 2024

Closed and reopened the PR to update the description with UI tests PR for CI check

@MiriSafra MiriSafra closed this Sep 18, 2024
@mguetta1 mguetta1 reopened this Sep 18, 2024
@rszwajko rszwajko changed the title ✨ change icons in S_G table ✨ Update stakeholder groups table to use ActionsColumn Sep 26, 2024
@rszwajko
Copy link
Collaborator

@MiriSafra PR looks good - I've changed the title so that it would look more like previous work on this topic - see #1923

@rszwajko rszwajko merged commit c04bb35 into konveyor:main Sep 26, 2024
36 of 38 checks passed
sarinailinger pushed a commit to sarinailinger/tackle2-ui that referenced this pull request Oct 30, 2024
Addition ActionsColumn to  Stakeholder groups table
Relates to konveyor#1318
UI tests PR: 1222

Signed-off-by: MiriSafra <M0533175827@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants