Skip to content

Commit 2f0985e

Browse files
committed
fix a number of Makefile.third rules
- using `$@` for some of those multiple-targets rules is a mistake (it's not going be the library name when triggered by a dependency on the include directory) - add missing targets (include directory, library names)
1 parent 2d29453 commit 2f0985e

File tree

1 file changed

+20
-20
lines changed

1 file changed

+20
-20
lines changed

Makefile.third

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ $(FREETYPE_LIB) $(FREETYPE_DIR)/include: $(THIRDPARTY_DIR)/freetype2/*.*
2525
-DLDFLAGS='$(LDFLAGS)' \
2626
$(CURDIR)/$(THIRDPARTY_DIR)/freetype2 && \
2727
$(CMAKE_MAKE_PROGRAM) $(CMAKE_MAKE_PROGRAM_FLAGS)
28-
cp -fL $(FREETYPE_DIR)/$(if $(WIN32),bin,lib)/$(notdir $(FREETYPE_LIB)) $@
28+
cp -fL $(FREETYPE_DIR)/$(if $(WIN32),bin,lib)/$(notdir $(FREETYPE_LIB)) $(FREETYPE_LIB)
2929

3030
$(HARFBUZZ_LIB) $(HARFBUZZ_DIR)/include: $(THIRDPARTY_DIR)/harfbuzz/*.*
3131
install -d $(HARFBUZZ_BUILD_DIR)
@@ -41,7 +41,7 @@ $(HARFBUZZ_LIB) $(HARFBUZZ_DIR)/include: $(THIRDPARTY_DIR)/harfbuzz/*.*
4141
-DFREETYPE_DIR='$(FREETYPE_DIR)' \
4242
$(CURDIR)/$(THIRDPARTY_DIR)/harfbuzz && \
4343
$(CMAKE_MAKE_PROGRAM) $(CMAKE_MAKE_PROGRAM_FLAGS)
44-
cp -fL $(HARFBUZZ_DIR)/lib/$(notdir $(HARFBUZZ_LIB)) $@
44+
cp -fL $(HARFBUZZ_DIR)/lib/$(notdir $(HARFBUZZ_LIB)) $(HARFBUZZ_LIB)
4545

4646
$(UTF8PROC_LIB) $(UTF8PROC_DIR): $(THIRDPARTY_DIR)/utf8proc/*.*
4747
install -d $(UTF8PROC_BUILD_DIR)
@@ -53,15 +53,15 @@ $(UTF8PROC_LIB) $(UTF8PROC_DIR): $(THIRDPARTY_DIR)/utf8proc/*.*
5353
-DLDFLAGS='$(LDFLAGS)' \
5454
$(CURDIR)/$(THIRDPARTY_DIR)/utf8proc && \
5555
$(CMAKE_MAKE_PROGRAM) $(CMAKE_MAKE_PROGRAM_FLAGS)
56-
cp -fL $(UTF8PROC_DIR)/$(notdir $(UTF8PROC_LIB)) $@
57-
chmod 755 $@
56+
cp -fL $(UTF8PROC_DIR)/$(notdir $(UTF8PROC_LIB)) $(UTF8PROC_LIB)
57+
chmod 755 $(UTF8PROC_LIB)
5858
ifdef DARWIN
5959
install_name_tool -id \
6060
libs/$(notdir $(UTF8PROC_LIB)) \
6161
$(UTF8PROC_LIB)
6262
endif
6363

64-
$(FRIBIDI_LIB) $(FRIBIDI_DIR): $(THIRDPARTY_DIR)/fribidi/*.*
64+
$(FRIBIDI_LIB) $(FRIBIDI_DIR)/include: $(THIRDPARTY_DIR)/fribidi/*.*
6565
install -d $(FRIBIDI_BUILD_DIR)
6666
cd $(FRIBIDI_BUILD_DIR) && \
6767
$(CMAKE) $(CMAKE_FLAGS) \
@@ -71,10 +71,10 @@ $(FRIBIDI_LIB) $(FRIBIDI_DIR): $(THIRDPARTY_DIR)/fribidi/*.*
7171
-DLDFLAGS='$(LDFLAGS)' \
7272
$(CURDIR)/$(THIRDPARTY_DIR)/fribidi && \
7373
$(CMAKE_MAKE_PROGRAM) $(CMAKE_MAKE_PROGRAM_FLAGS)
74-
cp -fL $(FRIBIDI_DIR)/lib/$(notdir $(FRIBIDI_LIB)) $@
75-
chmod 755 $@
74+
cp -fL $(FRIBIDI_DIR)/lib/$(notdir $(FRIBIDI_LIB)) $(FRIBIDI_LIB)
75+
chmod 755 $(FRIBIDI_LIB)
7676

77-
$(LIBUNIBREAK_LIB) $(LIBUNIBREAK_DIR): $(THIRDPARTY_DIR)/libunibreak/*.*
77+
$(LIBUNIBREAK_LIB) $(LIBUNIBREAK_DIR)/include: $(THIRDPARTY_DIR)/libunibreak/*.*
7878
install -d $(LIBUNIBREAK_BUILD_DIR)
7979
cd $(LIBUNIBREAK_BUILD_DIR) && \
8080
$(CMAKE) $(CMAKE_FLAGS) \
@@ -84,11 +84,11 @@ $(LIBUNIBREAK_LIB) $(LIBUNIBREAK_DIR): $(THIRDPARTY_DIR)/libunibreak/*.*
8484
-DLDFLAGS='$(LDFLAGS)' \
8585
$(CURDIR)/$(THIRDPARTY_DIR)/libunibreak && \
8686
$(CMAKE_MAKE_PROGRAM) $(CMAKE_MAKE_PROGRAM_FLAGS)
87-
cp -fL $(LIBUNIBREAK_DIR)/lib/$(notdir $(LIBUNIBREAK_LIB)) $@
88-
chmod 755 $@
87+
cp -fL $(LIBUNIBREAK_DIR)/lib/$(notdir $(LIBUNIBREAK_LIB)) $(LIBUNIBREAK_LIB)
88+
chmod 755 $(LIBUNIBREAK_LIB)
8989

9090
# libjpeg-turbo and libjpeg
91-
$(TURBOJPEG_LIB) $(JPEG_LIB): $(THIRDPARTY_DIR)/libjpeg-turbo/*.*
91+
$(TURBOJPEG_LIB) $(JPEG_LIB) $(JPEG_DIR)/include: $(THIRDPARTY_DIR)/libjpeg-turbo/*.*
9292
install -d $(JPEG_BUILD_DIR)
9393
cd $(JPEG_BUILD_DIR) && \
9494
$(CMAKE) $(CMAKE_FLAGS) \
@@ -105,7 +105,7 @@ ifdef DARWIN
105105
$(TURBOJPEG_LIB)
106106
endif
107107

108-
$(PNG_LIB): $(ZLIB) $(THIRDPARTY_DIR)/libpng/*.*
108+
$(PNG_LIB) $(PNG_DIR)/include: $(ZLIB) $(THIRDPARTY_DIR)/libpng/*.*
109109
install -d $(PNG_BUILD_DIR)
110110
cd $(PNG_BUILD_DIR) && \
111111
$(CMAKE) $(CMAKE_FLAGS) \
@@ -116,7 +116,7 @@ $(PNG_LIB): $(ZLIB) $(THIRDPARTY_DIR)/libpng/*.*
116116
-DLDFLAGS='$(LDFLAGS) -L$(ZLIB_DIR)' \
117117
$(CURDIR)/$(THIRDPARTY_DIR)/libpng && \
118118
$(CMAKE_MAKE_PROGRAM) $(CMAKE_MAKE_PROGRAM_FLAGS)
119-
cp -fL $(PNG_DIR)/.libs/$(notdir $(PNG_LIB)) $@
119+
cp -fL $(PNG_DIR)/.libs/$(notdir $(PNG_LIB)) $(PNG_LIB)
120120

121121
$(AES_LIB): $(THIRDPARTY_DIR)/minizip/*.*
122122
install -d $(MINIZIP_BUILD_DIR)
@@ -132,7 +132,7 @@ $(AES_LIB): $(THIRDPARTY_DIR)/minizip/*.*
132132

133133
# by default, mupdf compiles to a static library:
134134
# we generate a dynamic library from the static library:
135-
$(MUPDF_LIB) $(MUPDF_DIR)/include: $(JPEG_LIB) \
135+
$(MUPDF_LIB) $(MUPDF_DIR)/include $(MUPDF_DIR)/scripts: $(JPEG_LIB) \
136136
$(FREETYPE_LIB) $(FREETYPE_DIR)/include \
137137
$(HARFBUZZ_LIB) $(HARFBUZZ_DIR)/include \
138138
$(LIBWEBP_LIB) $(LIBWEBP_DIR)/include \
@@ -196,7 +196,7 @@ $(GIF_LIB): $(THIRDPARTY_DIR)/giflib/*.*
196196
$(CMAKE_MAKE_PROGRAM) $(CMAKE_MAKE_PROGRAM_FLAGS)
197197
cp -fL $(GIF_DIR)/lib/$(notdir $(GIF_LIB)) $@
198198

199-
$(LIBWEBP_LIB) $(LIBWEBP_DIR): $(THIRDPARTY_DIR)/libwebp/*.*
199+
$(LIBWEBP_LIB) $(LIBWEBPDEMUX_LIB) $(LIBSHARPYUV_LIB) $(LIBWEBP_DIR)/include: $(THIRDPARTY_DIR)/libwebp/*.*
200200
install -d $(LIBWEBP_BUILD_DIR)
201201
cd $(LIBWEBP_BUILD_DIR) && \
202202
$(CMAKE) $(CMAKE_FLAGS) \
@@ -209,12 +209,12 @@ $(LIBWEBP_LIB) $(LIBWEBP_DIR): $(THIRDPARTY_DIR)/libwebp/*.*
209209
-DLDFLAGS='$(LDFLAGS)' \
210210
$(CURDIR)/$(THIRDPARTY_DIR)/libwebp && \
211211
$(CMAKE_MAKE_PROGRAM) $(CMAKE_MAKE_PROGRAM_FLAGS)
212-
cp -fL $(LIBWEBP_DIR)/lib/$(notdir $(LIBWEBP_LIB)) $@
212+
cp -fL $(LIBWEBP_DIR)/lib/$(notdir $(LIBWEBP_LIB)) $(LIBWEBP_LIB)
213213
cp -fL $(LIBWEBP_DIR)/lib/$(notdir $(LIBWEBPDEMUX_LIB)) $(LIBWEBPDEMUX_LIB)
214214
cp -fL $(LIBWEBP_DIR)/lib/$(notdir $(LIBSHARPYUV_LIB)) $(LIBSHARPYUV_LIB)
215-
chmod 755 $@
215+
chmod 755 $(LIBWEBP_LIB) $(LIBWEBPDEMUX_LIB) $(LIBSHARPYUV_LIB)
216216

217-
$(LUNASVG_LIB): $(THIRDPARTY_DIR)/lunasvg/*.*
217+
$(LUNASVG_LIB) $(LUNASVG_DIR)/include: $(THIRDPARTY_DIR)/lunasvg/*.*
218218
install -d $(LUNASVG_BUILD_DIR)
219219
cd $(LUNASVG_BUILD_DIR) && \
220220
$(CMAKE) $(CMAKE_FLAGS) \
@@ -517,7 +517,7 @@ else
517517
cp -fL $(ZLIB_DIR)/lib/$(notdir $(ZLIB)) $(ZLIB)
518518
endif
519519

520-
$(ZSTD_LIB): $(THIRDPARTY_DIR)/zstd/*.*
520+
$(ZSTD_LIB) $(ZSTD_DESTDIR)/include: $(THIRDPARTY_DIR)/zstd/*.*
521521
install -d $(ZSTD_BUILD_DIR)
522522
cd $(ZSTD_BUILD_DIR) && \
523523
$(CMAKE) $(CMAKE_FLAGS) \
@@ -528,7 +528,7 @@ $(ZSTD_LIB): $(THIRDPARTY_DIR)/zstd/*.*
528528
-DLDFLAGS='$(LDFLAGS)' \
529529
$(CURDIR)/$(THIRDPARTY_DIR)/zstd && \
530530
$(CMAKE_MAKE_PROGRAM) $(CMAKE_MAKE_PROGRAM_FLAGS)
531-
cp -fL $(ZSTD_DIR)/lib/$(notdir $(ZSTD_LIB)) $@
531+
cp -fL $(ZSTD_DIR)/lib/$(notdir $(ZSTD_LIB)) $(ZSTD_LIB)
532532

533533
# ===========================================================================
534534
# console version of StarDict (sdcv)

0 commit comments

Comments
 (0)