1.1.12

[koriym]

• Better PHP8 support

---

This discussion was created from the release 1.1.12.

[kenjis]

The config for path coverage is gone in 1.1.12.
This commit 0a3c4f9 is gone.

$ git diff 1.1.11...1.1.12 phpunit.xml.dist
diff --git a/phpunit.xml.dist b/phpunit.xml.dist
index 96582b0..f92548e 100644
--- a/phpunit.xml.dist
+++ b/phpunit.xml.dist
@@ -1,20 +1,20 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-  xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/9.3/phpunit.xsd"
-  bootstrap="vendor/autoload.php">
-  <coverage cacheDirectory=".phpunit.cache/code-coverage"
-    processUncoveredFiles="true"
-    pathCoverage="true">
-    <include>
-      <directory suffix=".php">src</directory>
-    </include>
-  </coverage>
-  <testsuites>
-    <testsuite name="all">
-      <directory>tests</directory>
-    </testsuite>
-  </testsuites>
-  <php>
-    <ini name="error_reporting" value="-1"/>
-  </php>
+<phpunit
+    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+    xsi:noNamespaceSchemaLocation="./vendor/phpunit/phpunit/phpunit.xsd"
+    bootstrap="vendor/autoload.php"
+>
+    <testsuites>
+        <testsuite name="__Vendor__.__Package__ test suite">
+            <directory>tests</directory>
+        </testsuite>
+    </testsuites>
+    <coverage processUncoveredFiles="true">
+        <include>
+            <directory suffix=".php">src</directory>
+        </include>
+    </coverage>
+    <php>
+        <ini name="error_reporting" value="-1"/>
+    </php>
 </phpunit>

[kenjis]

@koriym It seems the change commit is 953cf64 , but there is no pathCoverage in the diff.
It is strange.

[kenjis]

This merge commit overrided my changes?

[koriym]

Yes, I think I've done something wrong.
However, I don't think pathCoverage="true" is necessary in the default options.

Only xdebug is supported, and I think it's better to keep it simple by default.

[kenjis]

Only xdebug is supported

It's very bad news!

I think line coverage is not enough. But It's hard to make it the default config.

[koriym]

phpdbg doesn't work even for line coverage with pathCoverage=1

% phpdbg -qrr ./vendor/bin/phpunit --coverage-htm coverage
PHPUnit 9.5.6 by Sebastian Bergmann and contributors.

Warning:       No code coverage driver with path coverage support available

............................                                      28 / 28 (100%)

Time: 00:00.059, Memory: 18.00 MB

[koriym]

If the package supports only Xdebug coverage (not this package), it's fairly easy to set up.
Shouldn't be a problem.