Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Qulice to police the code quality #4

Open
3 of 5 tasks
korthout opened this issue Jan 6, 2019 · 2 comments
Open
3 of 5 tasks

Add Qulice to police the code quality #4

korthout opened this issue Jan 6, 2019 · 2 comments

Comments

@korthout
Copy link
Owner

korthout commented Jan 6, 2019

Qulice can restrict what kind of code is allowed by breaking the build if the code does not comply.

  • Add Qulice to pom file
  • Resolve PMD violations
  • Resolve Checkstyle violations
  • Resolve FindBugs violations
  • Make Qulice a standard part of the Travis build
@korthout
Copy link
Owner Author

korthout commented Jan 6, 2019

There is an issue with FindBugs that needs to be fixed concerning jdk11. Qulice will break the build because of it. Continue after yegor256/qulice#878 is resolved.

@korthout
Copy link
Owner Author

For now it looks like the issue in Qulice will not be fixed soon. Perhaps Findbugs can be disabled completely to at least have a successful build while still be able to use the advantages of checkstyle and pmd via qulice. If so, it might be a good idea to look into applying Spotbugs separately. If not, Qulice can also be replaced by applying Checkstyle and PMD separately, although some checks will be lost. Please investigate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant