Skip to content
This repository has been archived by the owner on Sep 8, 2019. It is now read-only.

Latest commit

 

History

History
49 lines (42 loc) · 2.7 KB

README.md

File metadata and controls

49 lines (42 loc) · 2.7 KB

MIT Licensed Kottans-Frontend        Telegram

Frontend 2019 course homeworks

This repo was created for students to submit their homeworks for review.

How to submit

  • fork this repository

  • clone your fork to your local machine: git clone https://github.com/YOUR_USERNAME/frontend-2019-homeworks.git

  • add this repository as an upstream: git remote add upstream https://github.com/kottans/frontend-2019-homeworks.git

  • in your local repository, add a folder with your github name under submissions (if you haven't yet)

  • in your local repository, under your name folder, add a folder with task name and put your code in the folder

    See example file structure you are expected to have below:

    File structure example

  • make pull-request to this repository following these steps:

    • git checkout master and then create new branch, name it according to task performed (aka feature branch): git checkout -b dom-api-task. In this example feature branch is called dom-api-task
    • commit your changes to newly created feature branch
    • checkout master branch: git checkout master
    • pull latest changes from upstream master branch: git pull upstream master
    • merge master branch into your feature branch: git checkout dom-api-task && git merge master
    • resolve any merge conflicts if there are any
    • push feature branch to your remote repository: git push --set-upstream origin dom-api-task
    • make pull-request from your repository to this repository via GitHub web-interface
  • post a link to your subtask PR in the FE Questionarium chat and ask mentors for a code review

    • wait for review from course mentors
    • if necessary, make changes, until your code will be approved and merged
    • once the code review phase successfully finished and you have an approval from one of the mentors add to your kottans-frontend/README.md a link to subtask code base and a note saying Reviewed and approved by @<mentor> (use mentor's github username)
    • list your reflections on this subtask (what was new to you, what surprised you, what you intend to use in future)