diff --git a/cpp/src/arrow/array/statistics.h b/cpp/src/arrow/array/statistics.h index 7357e27f41f5b..9602a67fae9a5 100644 --- a/cpp/src/arrow/array/statistics.h +++ b/cpp/src/arrow/array/statistics.h @@ -34,9 +34,7 @@ namespace arrow { /// as Apache Parquet may have statistics. Statistics associated with /// data source can be read unified API via this class. struct ARROW_EXPORT ArrayStatistics { - using ValueType = - std::variant; + using ValueType = std::variant; ArrayStatistics() = default; ~ArrayStatistics() = default; diff --git a/cpp/src/arrow/array/statistics_test.cc b/cpp/src/arrow/array/statistics_test.cc index a465ac0bc2e0d..949277be7ffb0 100644 --- a/cpp/src/arrow/array/statistics_test.cc +++ b/cpp/src/arrow/array/statistics_test.cc @@ -41,11 +41,11 @@ TEST(ArrayStatisticsTest, TestMin) { ArrayStatistics statistics; ASSERT_FALSE(statistics.min.has_value()); ASSERT_FALSE(statistics.is_min_exact.has_value()); - statistics.min = static_cast(29); + statistics.min = static_cast(29); statistics.is_min_exact = true; ASSERT_TRUE(statistics.min.has_value()); - ASSERT_TRUE(std::holds_alternative(statistics.min.value())); - ASSERT_EQ(29, std::get(statistics.min.value())); + ASSERT_TRUE(std::holds_alternative(statistics.min.value())); + ASSERT_EQ(29, std::get(statistics.min.value())); ASSERT_TRUE(statistics.is_min_exact.has_value()); ASSERT_TRUE(statistics.is_min_exact.value()); } @@ -79,9 +79,9 @@ TEST(ArrayStatisticsTest, TestEquality) { statistics2.distinct_count = 2929; ASSERT_EQ(statistics1, statistics2); - statistics1.min = std::string_view("world"); + statistics1.min = std::string("world"); ASSERT_NE(statistics1, statistics2); - statistics2.min = std::string_view("world"); + statistics2.min = std::string("world"); ASSERT_EQ(statistics1, statistics2); statistics1.is_min_exact = false; @@ -89,9 +89,9 @@ TEST(ArrayStatisticsTest, TestEquality) { statistics2.is_min_exact = false; ASSERT_EQ(statistics1, statistics2); - statistics1.max = arrow::util::Float16(-29); + statistics1.max = -29; ASSERT_NE(statistics1, statistics2); - statistics2.max = arrow::util::Float16(-29); + statistics2.max = -29; ASSERT_EQ(statistics1, statistics2); statistics1.is_max_exact = true;