-
Notifications
You must be signed in to change notification settings - Fork 13
Improve MacOs self signed certificate instructions #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
The mac instructions provided are missing a ton of flags required for support of various versions of java and library imports. Just adding the command line argument to the launcher is much simpler.
jonbartels
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will permanently disable cert checking in MCAL. The command line flags will allow the user to decide to run MCAL for dev to test plugins. Changing plist will make it permanent.
Provide instructions for both.
|
I wasn't able to get the command line alone working, including using the existing instructions in the README. This is the only way that I've found so far to get the launcher to run with the I'm no MacOS expert. There may be a way to make a separate application that does this. But at the very least these method works were the existing one in the README does not. |
|
I think the best choice would be to update your PR to include both options. Label one as "One Time Override" and the other as "Permanent Override" or something similar. The current The option you propose is actually really handy if the user has a need to make |
|
I have to agree with Jon here. While for someone who knows what they're doing, your suggestion is absolutely useful. I too have a separate shortcut that disables a bunch of security stuff, but I think disabling shouldn't be the default/recommended behavior. |
|
I also disagree with the change in this PR. Many people use the same machine for accessing production/remote instances that they also use for testing while developing plugins. This change intentionally removes necessary security safeguards. I don't know why the java version would have any impact on setting the flag. The flag is a parameter passed through to MCAL. It is not used by the java command itself. |
|
I am going to retract my objection to this PR. I was looking at the README for Windows. Changing the windows shortcut makes a similar change as the MacOS PLIST file. If its OK for Windows then its OK for Mac. @kpalang I think listing both permanent and not-permanent flag options is best. WDYT? |
The mac instructions provided are missing a ton of flags required for support of various versions of java and library imports. Just adding the command line argument to the launcher is much simpler.