-
[STYLES] - Get used to style all elements using classes. And don't increase selectors specificity unless completely necessary.
-
[STYLES] - Remember to use fallback fonts - alternative font-family in case the main one doesn't work like this
GOOD example:
font-family: Roboto, Helvetica, sans-serif;
BAD example:
font-family: Roboto, sans-serif;
-
[CODE STYLE] - Add empty lines between multiline sibling blocks of HTML. But don't add empty lines between parent and child elements
GOOD example:
<ul>
<li class="nav__item">
<a href="#home">Home</a>
</li>
<li class="nav__item">
<a href="#shop">Shop</a>
</li>
<li class="nav__item">
<a href="#contacts">Contacts</a>
</li>
</ul>
BAD example:
<ul>
<li class="nav__item">
<a href="#home">Home</a>
</li>
<li class="nav__item">
<a href="#shop">Shop</a>
</li>
<li class="nav__item">
<a href="#contacts">Contacts</a>
</li>
</ul>
- [TASK] - Make sure to reuse part of Stars task here, and keep it operational in case you change block modifier.
- [BEM] - Check your BEM structure using BEM-linter (
npm run lint
) and this list - [BEM] - Don't make BEM structure too complicated. You don't need to create separate blocks for anything other than card itself and stars.
- [BEM & STYLES] - Don't add external styles (positioning or margins) to BEM-blocks. Use mix where necessary and move all external styles under element selector.
GOOD example
<!--index.html-->
<div class="container">
<div class="container__card card">
...
</div>
</div>
/*styles.css*/
.container__card {
margin: 48px 24px;
}
.card {
font-size: 16px;
background-color: purple;
}
BAD example
<!--index.html-->
<div class="container">
<div class="card">
...
</div>
</div>
.card {
margin: 48px 24px;
font-size: 16px;
background-color: purple;
}
- [STYLES] - Don't hardcode exact height size. Add necessary paddings according to mockup and let content dictate the container size.
- [STYLES] - Don't add new border to the element on hover. Add default
transparent border of the same width, and change its color on
:hover
- [STYLES] - Be consistent with your margins. Add only top or bottom, don't add both.
- [FILE STRUCTURE] - You should create separate file for each BEM block
- [SEMANTICS] - Use semantic tags like h2, p ...
- [SEO] -
alt
atribute should describe the image if the image contains information (better description you have - better for you :))
REALLY BAD example:
<img alt="image" />
STILL BAD example:
<img alt="phone" />
GOOD example:
<img alt="Samsung Galaxy S22 2022 8/128GB Green" />
- [CODE STYLE] - If the HTML-element has long attribute values or number of attributes is more than 2 - start each one, including the first, on the new line with 2-space indentation related to tag. Tag’s closing bracket should be on the same level as opening one.