Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hide HandleRequest method from connection interface #63

Closed
ksysoev opened this issue Jun 2, 2024 · 1 comment
Closed

hide HandleRequest method from connection interface #63

ksysoev opened this issue Jun 2, 2024 · 1 comment
Assignees

Comments

@ksysoev
Copy link
Owner

ksysoev commented Jun 2, 2024

We can simplify connection interface by refactoring some current logic

currently we block with handling request inside channel abstraction, but if we move this processing inside connection registry, we'll be able to hide HandleRequests from public.
Other benefit that we'll be able to hand on close signal directly in connection registry. without onClose channel, and remove such responsibility from connection abstraction.

@ksysoev ksysoev self-assigned this Jun 2, 2024
@ksysoev
Copy link
Owner Author

ksysoev commented Jun 2, 2024

implemented in #65

@ksysoev ksysoev closed this as completed Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant