Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make GH action running for outside pull request #67

Closed
ksysoev opened this issue Jun 4, 2024 · 6 comments
Closed

Make GH action running for outside pull request #67

ksysoev opened this issue Jun 4, 2024 · 6 comments

Comments

@ksysoev
Copy link
Owner

ksysoev commented Jun 4, 2024

Current configuration of workflow doesn't work for outside contributors, need to understand what is missing.

@shan-96
Copy link
Contributor

shan-96 commented Jun 7, 2024

Hey @ksysoev can you check if the repo settings have an option to enable this?
image

@ksysoev
Copy link
Owner Author

ksysoev commented Jun 8, 2024

@shan-96 I didn't manage to find exactly this screen, could you guide me how to find it?

The closest I managed to find, is this one:

image

I assume I need to add additional trigger for workflow pull_request_target

https://docs.github.com/en/actions/managing-workflow-runs/approving-workflow-runs-from-public-forks

@ksysoev
Copy link
Owner Author

ksysoev commented Jun 8, 2024

Hope fully it's addressed in #70, lets wait until next commit in your PR.

@shan-96
Copy link
Contributor

shan-96 commented Jun 8, 2024

Great! btw I found the setting at https://github.com/{user}/{repository}/settings/actions

@ksysoev
Copy link
Owner Author

ksysoev commented Jun 8, 2024

@shan-96 my screenshot from the same page, not sure why it looks different for me

@shan-96
Copy link
Contributor

shan-96 commented Jun 8, 2024

it works - https://github.com/ksysoev/wasabi/actions/runs/9428231062/job/25973304242?pr=76

@ksysoev ksysoev closed this as completed Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants