From ec28150efa735dfa1d176d39786b26c8ce881b91 Mon Sep 17 00:00:00 2001
From: Giulio Eulisse <10544+ktf@users.noreply.github.com>
Date: Tue, 7 Nov 2023 11:36:02 +0100
Subject: [PATCH] C++20 disables aggregate initialisation if default
 constructors found

---
 DataFormats/Detectors/CTP/include/DataFormatsCTP/Digits.h | 2 --
 .../Detectors/CTP/include/DataFormatsCTP/LumiInfo.h       | 1 -
 .../include/ITSMFTReconstruction/Clusterer.h              | 1 -
 .../reconstruction/include/ITS3Reconstruction/Clusterer.h | 1 -
 Framework/Core/include/Framework/DeviceSpec.h             | 8 +++-----
 Framework/Core/src/DeviceSpecHelpers.cxx                  | 1 +
 6 files changed, 4 insertions(+), 10 deletions(-)

diff --git a/DataFormats/Detectors/CTP/include/DataFormatsCTP/Digits.h b/DataFormats/Detectors/CTP/include/DataFormatsCTP/Digits.h
index c05a59599e707..e1ef4de73f222 100644
--- a/DataFormats/Detectors/CTP/include/DataFormatsCTP/Digits.h
+++ b/DataFormats/Detectors/CTP/include/DataFormatsCTP/Digits.h
@@ -51,7 +51,6 @@ struct CTPDigit {
   o2::InteractionRecord intRecord;
   std::bitset<CTP_NINPUTS> CTPInputMask;
   std::bitset<CTP_NCLASSES> CTPClassMask;
-  CTPDigit() = default;
   void printStream(std::ostream& stream) const;
   void setInputMask(gbtword80_t mask);
   void setClassMask(gbtword80_t mask);
@@ -72,7 +71,6 @@ struct CTPInputDigit {
   o2::InteractionRecord intRecord;
   std::bitset<CTP_MAXTRIGINPPERDET> inputsMask;
   o2::detectors::DetID::ID detector;
-  CTPInputDigit() = default;
   ClassDefNV(CTPInputDigit, 1)
 };
 } // namespace ctp
diff --git a/DataFormats/Detectors/CTP/include/DataFormatsCTP/LumiInfo.h b/DataFormats/Detectors/CTP/include/DataFormatsCTP/LumiInfo.h
index e9eb8ba497c17..c75fcc32ddaf4 100644
--- a/DataFormats/Detectors/CTP/include/DataFormatsCTP/LumiInfo.h
+++ b/DataFormats/Detectors/CTP/include/DataFormatsCTP/LumiInfo.h
@@ -22,7 +22,6 @@ namespace o2
 namespace ctp
 {
 struct LumiInfo {
-  LumiInfo() = default;
   uint32_t orbit = 0;       // orbit of TF when was updated
   uint32_t nHBFCounted = 0; // length of interval in HB
   uint32_t nHBFCountedFV0 = 0;
diff --git a/Detectors/ITSMFT/common/reconstruction/include/ITSMFTReconstruction/Clusterer.h b/Detectors/ITSMFT/common/reconstruction/include/ITSMFTReconstruction/Clusterer.h
index e1636c93d035a..d79eb4ac2b460 100644
--- a/Detectors/ITSMFT/common/reconstruction/include/ITSMFTReconstruction/Clusterer.h
+++ b/Detectors/ITSMFT/common/reconstruction/include/ITSMFTReconstruction/Clusterer.h
@@ -118,7 +118,6 @@ class Clusterer
     uint32_t firstPatt = 0;
     uint32_t nClus = 0;
     uint32_t nPatt = 0;
-    ThreadStat() = default;
   };
 
   struct ClustererThread {
diff --git a/Detectors/Upgrades/ITS3/reconstruction/include/ITS3Reconstruction/Clusterer.h b/Detectors/Upgrades/ITS3/reconstruction/include/ITS3Reconstruction/Clusterer.h
index 6eda6e98f0b52..4008dfb215dd2 100644
--- a/Detectors/Upgrades/ITS3/reconstruction/include/ITS3Reconstruction/Clusterer.h
+++ b/Detectors/Upgrades/ITS3/reconstruction/include/ITS3Reconstruction/Clusterer.h
@@ -118,7 +118,6 @@ class Clusterer
     uint32_t firstPatt = 0;
     uint32_t nClus = 0;
     uint32_t nPatt = 0;
-    ThreadStat() = default;
   };
 
   struct ClustererThread {
diff --git a/Framework/Core/include/Framework/DeviceSpec.h b/Framework/Core/include/Framework/DeviceSpec.h
index 6a11146283190..a22fc7eb1b7dc 100644
--- a/Framework/Core/include/Framework/DeviceSpec.h
+++ b/Framework/Core/include/Framework/DeviceSpec.h
@@ -46,13 +46,11 @@ namespace o2::framework
 ///
 /// auto &deviceSpec = ctx.services().get<DeviceSpec const>();
 struct DeviceSpec {
-  DeviceSpec(const DeviceSpec&) = delete;
-  DeviceSpec(DeviceSpec&&) = default;
   /// The name of the associated DataProcessorSpec
-  std::string name;
+  std::string name = "unknown";
   /// The id of the device, including time-pipelining and suffix
-  std::string id;
-  std::string channelPrefix;
+  std::string id = "unknown";
+  std::string channelPrefix = "";
   std::vector<InputChannelSpec> inputChannels;
   std::vector<OutputChannelSpec> outputChannels;
   std::vector<std::string> arguments;
diff --git a/Framework/Core/src/DeviceSpecHelpers.cxx b/Framework/Core/src/DeviceSpecHelpers.cxx
index f11f60171e451..969a15fa40674 100644
--- a/Framework/Core/src/DeviceSpecHelpers.cxx
+++ b/Framework/Core/src/DeviceSpecHelpers.cxx
@@ -534,6 +534,7 @@ void DeviceSpecHelpers::processOutEdgeActions(ConfigContext const& configContext
       .name = processor.name,
       .id = processor.maxInputTimeslices == 1 ? processor.name : processor.name + "_t" + std::to_string(edge.producerTimeIndex),
       .channelPrefix = channelPrefix,
+      .inputChannels = {},
       .options = processor.options,
       .services = ServiceSpecHelpers::filterDisabled(processor.requiredServices, overrideServices),
       .algorithm = processor.algorithm,