Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the yumi_cameras FTP server code #16

Open
YoshuaNava opened this issue Jan 21, 2018 · 0 comments
Open

Improve the yumi_cameras FTP server code #16

YoshuaNava opened this issue Jan 21, 2018 · 0 comments
Assignees

Comments

@YoshuaNava
Copy link
Collaborator

YoshuaNava commented Jan 21, 2018

When I worked on this package, it was required to have the cameras running as quickly as possible. Hence, at this moment the FTP server code is pretty straightforward, and does what's expected, but does not follow best practices (for example). It could become a class, with comments, and enough functions to start, stop and restart the server.

The C++ code for triggering the cameras could also be encapsulated and documented better.

@YoshuaNava YoshuaNava self-assigned this Jan 21, 2018
@kth-ros-pkg kth-ros-pkg deleted a comment from diogoalmeida Jan 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant