Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scaling or pre-sizing images #192

Open
Cinemacloud opened this issue Jan 4, 2024 · 9 comments
Open

Scaling or pre-sizing images #192

Cinemacloud opened this issue Jan 4, 2024 · 9 comments
Labels
enhancement New feature or request

Comments

@Cinemacloud
Copy link

How do I resize or configure the size at build? I didn't see much mention of that but perhaps entirely a docker concern and question?

@ktock
Copy link
Owner

ktock commented Jan 5, 2024

Is this duplication of #191 ?

EDIT: I've added some comments on that thread.

@Cinemacloud
Copy link
Author

More or less but curious how I can at least tweak storage size (through Docker?) before its implemented in c2w itself.. or not possible?

@ktock
Copy link
Owner

ktock commented Jan 5, 2024

tweak storage size (through Docker?)

Could you elaborate what "storage" means? The storage usage by docker during build? Or the output Wasm image size? Or the disk size of the container(VM) running on browser?

@Cinemacloud
Copy link
Author

yes, practically I was just updating the packages and it quickly ran out of space and stopped working.

@ktock
Copy link
Owner

ktock commented Jan 5, 2024

We rely on docker build for generating wasm images so it sounds like Docker's concern. If it's ok to remove your Docker build cache, Docker provides docker builder prune for removing build cache and increasing free space. https://docs.docker.com/engine/reference/commandline/builder_prune/

@Cinemacloud
Copy link
Author

So c2w has no practical limits other than Docker prescribes via images and containers?

@ktock
Copy link
Owner

ktock commented Jan 6, 2024

Yes. If needed, we can fix c2w to optionally use some flags of docker build for limiting resource usage: https://docs.docker.com/engine/reference/commandline/build/#options

@Cinemacloud
Copy link
Author

That would be awesome or show me how I can do it in few steps I plan to use this in a big project poc, thanks!

@ktock ktock added the enhancement New feature or request label Jan 9, 2024
@Cinemacloud
Copy link
Author

Just curious if you were able to give hardware scaling params into build yet and also could you put together a demo using Neko browser which is docker based already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants