ktsu.Semantics.StrongString writes as a string array

[Damon3000s]

When writing a ktsu.Semantics.StrongString variable it will write as a char array and not a string

The code I used to test/confirm:

internal sealed class TestAppData : AppData<TestAppData>
{
	public string Data { get; set; } = string.Empty;
	public AbsoluteDirectoryPath Path { get; } = "C:\\temp".As<AbsoluteDirectoryPath>();
}

The output I got:

{
  "$id": "1",
  "Data": "Data for file 1",
  "Path": {
    "$id": "2",
    "$values": [
      "C",
      ":",
      "\\",
      "t",
      "e",
      "m",
      "p"
    ]
  }
}

[matt-edmondson]

I beleive this is because I switched to ktsu.RoundTripStringJsonConverter, from ktsu.ToStringJsonConverter which had built-in support for StrongStrings and therefore a dependency I was trying to break

I wrongly remembered semantic strings having a FromString method which would have matched the requirements for the new converter

im working on the polyfills for that right now so I'll add it and then update the downstream packages

[matt-edmondson]

I just checked and these are the methods RoundTrip is looking for:

private static readonly string[] SupportedMethodNames = ["FromString", "Parse", "Create", "Convert"];

so it's supposed to work.

I will need to set up some integration testing for this case to debug it.

[matt-edmondson]

I imagine its related to the fact that the Create method on Semantics are generic.