From 2a2ac5402cf683ccf04068fdf3f4e0bd4024862d Mon Sep 17 00:00:00 2001
From: Darcy Abell <Darcy@thethreethousands.com>
Date: Mon, 19 Jan 2026 10:59:53 +1100
Subject: [PATCH] Only validate fully qualified directory paths

---
 Semantics.Paths/Implementations/AbsoluteDirectoryPath.cs    | 2 +-
 Semantics.Paths/Implementations/DirectoryPath.cs            | 2 +-
 Semantics.Paths/SemanticDirectoryPath.cs                    | 2 +-
 Semantics.Paths/SemanticRelativePath.cs                     | 4 ++--
 ...PathAttribute.cs => IsAbsoluteDirectoryPathAttribute.cs} | 6 +++---
 Semantics.Test/PathValidationAttributeTests.cs              | 2 +-
 6 files changed, 9 insertions(+), 9 deletions(-)
 rename Semantics.Paths/Validation/Attributes/Path/{IsDirectoryPathAttribute.cs => IsAbsoluteDirectoryPathAttribute.cs} (84%)

diff --git a/Semantics.Paths/Implementations/AbsoluteDirectoryPath.cs b/Semantics.Paths/Implementations/AbsoluteDirectoryPath.cs
index 3300d3a..3ad2203 100644
--- a/Semantics.Paths/Implementations/AbsoluteDirectoryPath.cs
+++ b/Semantics.Paths/Implementations/AbsoluteDirectoryPath.cs
@@ -9,7 +9,7 @@ namespace ktsu.Semantics.Paths;
 /// <summary>
 /// Represents an absolute directory path
 /// </summary>
-[IsPath, IsAbsolutePath, IsDirectoryPath]
+[IsPath, IsAbsolutePath, IsAbsoluteDirectoryPath]
 public sealed record AbsoluteDirectoryPath : SemanticDirectoryPath<AbsoluteDirectoryPath>, IAbsoluteDirectoryPath
 {
 	// Cache for expensive parent directory computation
diff --git a/Semantics.Paths/Implementations/DirectoryPath.cs b/Semantics.Paths/Implementations/DirectoryPath.cs
index 50d5c30..6e8a55f 100644
--- a/Semantics.Paths/Implementations/DirectoryPath.cs
+++ b/Semantics.Paths/Implementations/DirectoryPath.cs
@@ -9,7 +9,7 @@ namespace ktsu.Semantics.Paths;
 /// <summary>
 /// Represents a directory path (path to a directory)
 /// </summary>
-[IsPath, IsDirectoryPath]
+[IsPath, IsAbsoluteDirectoryPath]
 public sealed record DirectoryPath : SemanticDirectoryPath<DirectoryPath>, IDirectoryPath
 {
 	/// <summary>
diff --git a/Semantics.Paths/SemanticDirectoryPath.cs b/Semantics.Paths/SemanticDirectoryPath.cs
index e9ea7dc..a13280f 100644
--- a/Semantics.Paths/SemanticDirectoryPath.cs
+++ b/Semantics.Paths/SemanticDirectoryPath.cs
@@ -7,7 +7,7 @@ namespace ktsu.Semantics.Paths;
 /// <summary>
 /// Base class for directory paths (paths that represent directories)
 /// </summary>
-[IsPath, IsDirectoryPath]
+[IsPath]
 public abstract record SemanticDirectoryPath<TDerived> : SemanticPath<TDerived>
 	where TDerived : SemanticDirectoryPath<TDerived>
 {
diff --git a/Semantics.Paths/SemanticRelativePath.cs b/Semantics.Paths/SemanticRelativePath.cs
index 37468fb..07eab3a 100644
--- a/Semantics.Paths/SemanticRelativePath.cs
+++ b/Semantics.Paths/SemanticRelativePath.cs
@@ -80,11 +80,11 @@ public static TRelativePath Make<TRelativePath, TFromPath, TToPath>(TFromPath fr
 	/// </summary>
 	/// <typeparam name="T">The type of semantic path to check.</typeparam>
 	/// <param name="path">The path instance to check.</param>
-	/// <returns><see langword="true"/> if the path type has the <see cref="IsDirectoryPathAttribute"/>; otherwise, <see langword="false"/>.</returns>
+	/// <returns><see langword="true"/> if the path type has the <see cref="IsAbsoluteDirectoryPathAttribute"/>; otherwise, <see langword="false"/>.</returns>
 	private static bool IsDirectoryPath<T>(T path) where T : SemanticPath<T>
 	{
 		// Check if it's a directory-specific type based on validation attributes
 		Type type = path.GetType();
-		return type.GetCustomAttributes(typeof(IsDirectoryPathAttribute), true).Length > 0;
+		return type.GetCustomAttributes(typeof(IsAbsoluteDirectoryPathAttribute), true).Length > 0;
 	}
 }
diff --git a/Semantics.Paths/Validation/Attributes/Path/IsDirectoryPathAttribute.cs b/Semantics.Paths/Validation/Attributes/Path/IsAbsoluteDirectoryPathAttribute.cs
similarity index 84%
rename from Semantics.Paths/Validation/Attributes/Path/IsDirectoryPathAttribute.cs
rename to Semantics.Paths/Validation/Attributes/Path/IsAbsoluteDirectoryPathAttribute.cs
index 80d2c80..d59797c 100644
--- a/Semantics.Paths/Validation/Attributes/Path/IsDirectoryPathAttribute.cs
+++ b/Semantics.Paths/Validation/Attributes/Path/IsAbsoluteDirectoryPathAttribute.cs
@@ -12,18 +12,18 @@ namespace ktsu.Semantics.Paths;
 /// Validates that a path represents a directory (not an existing file)
 /// </summary>
 [AttributeUsage(AttributeTargets.Class, AllowMultiple = false, Inherited = true)]
-public sealed class IsDirectoryPathAttribute : NativeSemanticStringValidationAttribute
+public sealed class IsAbsoluteDirectoryPathAttribute : NativeSemanticStringValidationAttribute
 {
 	/// <summary>
 	/// Creates the validation adapter for directory path validation.
 	/// </summary>
 	/// <returns>A validation adapter for directory paths</returns>
-	protected override ValidationAdapter CreateValidator() => new DirectoryPathValidator();
+	protected override ValidationAdapter CreateValidator() => new AbsoluteDirectoryPathValidator();
 
 	/// <summary>
 	/// validation adapter for directory paths.
 	/// </summary>
-	private sealed class DirectoryPathValidator : ValidationAdapter
+	private sealed class AbsoluteDirectoryPathValidator : ValidationAdapter
 	{
 		/// <summary>
 		/// Validates that a path represents a directory by ensuring it's not an existing file.
diff --git a/Semantics.Test/PathValidationAttributeTests.cs b/Semantics.Test/PathValidationAttributeTests.cs
index 4ee6b31..78f603d 100644
--- a/Semantics.Test/PathValidationAttributeTests.cs
+++ b/Semantics.Test/PathValidationAttributeTests.cs
@@ -421,7 +421,7 @@ public record TestRelativePath : SemanticString<TestRelativePath> { }
 [IsValidFileName]
 public record TestFileName : SemanticString<TestFileName> { }
 
-[IsDirectoryPath]
+[IsAbsoluteDirectoryPath]
 public record TestDirectoryPath : SemanticString<TestDirectoryPath> { }
 
 [IsFilePath]