From 81f08ca20c7512df5877dd087eec957c67763cb6 Mon Sep 17 00:00:00 2001 From: JimmyYang20 Date: Fri, 12 Aug 2022 17:09:32 +0800 Subject: [PATCH] Add check pylint script Signed-off-by: JimmyYang20 --- Makefile | 16 ++++++++++++++++ hack/make-rules/pylint.sh | 40 +++++++++++++++++++++++++++++++++++++++ 2 files changed, 56 insertions(+) create mode 100644 hack/make-rules/pylint.sh diff --git a/Makefile b/Makefile index 3fb679ca9..7a2316828 100644 --- a/Makefile +++ b/Makefile @@ -119,6 +119,22 @@ lint: hack/make-rules/lint.sh endif +define PYLINT_HELP_INFO +# run python lint check. +# +# Example: +# make pylint +# make pylint HELP=y +endef +.PHONY: pylint +ifeq ($(HELP),y) +pylint: + @echo "$$PYLINT_HELP_INFO" +else +pylint: + hack/make-rules/pylint.sh +endif + define CLEAN_HELP_INFO # Clean up the output of make. # diff --git a/hack/make-rules/pylint.sh b/hack/make-rules/pylint.sh new file mode 100644 index 000000000..4b2882168 --- /dev/null +++ b/hack/make-rules/pylint.sh @@ -0,0 +1,40 @@ +#!/usr/bin/env bash + +# Copyright 2020 The KubeEdge Authors. +# +# Licensed under the Apache License, Version 2.0 (the "License"); +# you may not use this file except in compliance with the License. +# You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +set -o errexit +set -o nounset +set -o pipefail + +SEDNA_ROOT="$(cd "$(dirname "${BASH_SOURCE[0]}")/../.." && pwd -P)" + +source "${SEDNA_ROOT}/hack/lib/init.sh" + +install_pylint() { + echo "installing pylint" + python3 -m pip install -U pylint + if [[ $? -ne 0 ]]; then + echo "failed to install pylint, exiting." + exit 1 + fi +} + +check_pylint() { + echo "checking pylint" + install_pylint + pylint ${SEDNA_ROOT}/lib +} + +check_pylint