Skip to content

Commit cabab5f

Browse files
authored
Merge pull request #445 from SherlockShemol/ji-controller-enhancement
JointInferenceService controller enhancement
2 parents 3342955 + bfa3a65 commit cabab5f

File tree

211 files changed

+21053
-189
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

211 files changed

+21053
-189
lines changed

pkg/globalmanager/controllers/featureextraction/featureextractionservice.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,7 @@ func (c *Controller) addDeployment(obj interface{}) {
150150
c.enqueueByDeployment(deployment)
151151
}
152152

153-
//deleteDeployment enqueues the FeatureExtractionService obj When a deleteDeployment is deleted
153+
// deleteDeployment enqueues the FeatureExtractionService obj When a deleteDeployment is deleted
154154
func (c *Controller) deleteDeployment(obj interface{}) {
155155
deployment, ok := obj.(*appsv1.Deployment)
156156

@@ -513,7 +513,7 @@ func (c *Controller) createFeatureExtractionWorker(service *sednav1.FeatureExtra
513513
}
514514

515515
// Create FE deployment AND related pods (as part of the deployment creation)
516-
_, err = runtime.CreateDeploymentWithTemplate(c.kubeClient, service, &service.Spec.DeploymentSpec, &workerParam, FEPort)
516+
_, err = runtime.CreateDeploymentWithTemplate(c.kubeClient, service, &service.Spec.DeploymentSpec, &workerParam)
517517
if err != nil {
518518
return fmt.Errorf("failed to create feature extraction deployment: %w", err)
519519
}

0 commit comments

Comments
 (0)