Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix FederatedLearningJob delete error #467

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

tangming1996
Copy link
Collaborator

What type of PR is this?
/kind bug

What this PR does / why we need it:
fix FederatedLearningJob delete error
Which issue(s) this PR fixes:

Fixes #466

@kubeedge-bot kubeedge-bot added the kind/bug Categorizes issue or PR as related to a bug. label Feb 14, 2025
@kubeedge-bot kubeedge-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 14, 2025
Signed-off-by: ming.tang <ming.tang@daocloud.io>
@tangming1996 tangming1996 force-pushed the bugfix/federal-learning branch from 6574384 to bff8fd4 Compare February 14, 2025 08:15
@hsj576
Copy link
Member

hsj576 commented Feb 20, 2025

/lgtm

@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 20, 2025
Copy link
Collaborator

@MooreZheng MooreZheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR aims to determine whether an instance is intendedly deleted by checking the job existance. The demo looks good on our routine meeting.

@MooreZheng
Copy link
Collaborator

/lgtm

@MooreZheng
Copy link
Collaborator

/approve

@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MooreZheng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 20, 2025
@kubeedge-bot kubeedge-bot merged commit 150cc1a into kubeedge:main Feb 20, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

After deleting the CR in federated learning, the Pod instances will keep restarting
4 participants