Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to kubeflow.org in repo metadata #818

Closed
pboyd opened this issue Feb 7, 2025 · 3 comments
Closed

Link to kubeflow.org in repo metadata #818

pboyd opened this issue Feb 7, 2025 · 3 comments

Comments

@pboyd
Copy link
Contributor

pboyd commented Feb 7, 2025

CLOMonitor complains about a missing website URL, and because there's no website URL it also complains about a missing trademark disclaimer. See kubeflow/website#3664 for background.

It uses the URL configured in the repo metadata (src), which is to say, the URL configured here:

Image


Image

@andreyvelich
Copy link
Member

Hi @pboyd, I've added the Kubeflow website there.
Does it look good right now ?

@pboyd
Copy link
Contributor Author

pboyd commented Feb 13, 2025

It's still failing on clomonitor.io, but it passes when I manually run their tool:

e021a425b0a5:~$ clomonitor-linter --check-set community --path /repo --url https://github.com/kubeflow/community

CLOMonitor linter results

Repository information

╭────────────┬───────────────────────────────────────╮
│ Local path ┆ /repo                                 │
├╌╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌┤
│ Remote url ┆ https://github.com/kubeflow/community │
├╌╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌┤
│ Check sets ┆ [Community]                           │
╰────────────┴───────────────────────────────────────╯

Score summary

╭────────────────┬───────╮
│     Section    ┆ Score │
╞════════════════╪═══════╡
│ Global         ┆   89  │
├╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌┤
│ Documentation  ┆   85  │
├╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌┤
│ License        ┆  n/a  │
├╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌┤
│ Best practices ┆  100  │
├╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌┤
│ Security       ┆  100  │
├╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌┤
│ Legal          ┆  100  │
╰────────────────┴───────╯

It should be OK whenever the site updates.

@pboyd
Copy link
Contributor Author

pboyd commented Feb 13, 2025

It's updated now. Thanks @andreyvelich

Image

@pboyd pboyd closed this as completed Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants