Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate suggestion volume reconcile from resumePolicy #1893

Open
a9p opened this issue Jun 10, 2022 · 2 comments · May be fixed by #1992
Open

Separate suggestion volume reconcile from resumePolicy #1893

a9p opened this issue Jun 10, 2022 · 2 comments · May be fixed by #1992
Labels
kind/feature lifecycle/frozen

Comments

@a9p
Copy link
Contributor

a9p commented Jun 10, 2022

/kind feature

Describe the solution you'd like
Volumes used by Suggestion services (e.g. PBT) currently rely on resumePolicy to be FromVolume to run properly. As the Suggestion volumes always need to be mounted, it should be independent of the resumePolicy field.

Anything else you would like to add:
Discussion around requested change: #1833 (comment)

Love this feature? Give it a 👍 We prioritize the features with the most 👍
@a9p a9p mentioned this issue Jun 10, 2022
Merged
1 task
@a9p a9p linked a pull request Nov 1, 2022 that will close this issue
Draft
1 task
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@andreyvelich
Copy link
Member

/lifecycle frozen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature lifecycle/frozen
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Suggestion volume resumePolicy override a9p/katib
2 participants
@andreyvelich @a9p