You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
What steps did you take and what happened:
It seems like scheduled runs, unlike manual runs, are not seeing proper substitutions of the pipeline name, and instead end up with the raw $ORIG_PR_NAME:
Example:
On the left is a manually triggered run, on the right is the scheduled run:
What did you expect to happen:
All instances of ORIG_PR_NAME are properly substituted for the PR name, just like for manually triggered runs.
Additional information:
We are also using this attribute to work around: #1292
by identifying the locations of all the artifacts within the step copy artifact step, this unfortunately doesn't work if this variable is not properly substituted in a recurring run.
Environment:
SDK Version: 1.5
Tekton Version (use tkn version): 0.47
Kubernetes Version (use kubectl version): 1.26
OS (e.g. from /etc/os-release): fedora 37
The text was updated successfully, but these errors were encountered:
/kind bug
What steps did you take and what happened:
It seems like scheduled runs, unlike manual runs, are not seeing proper substitutions of the pipeline name, and instead end up with the raw
$ORIG_PR_NAME
:Example:
On the left is a manually triggered run, on the right is the scheduled run:
Furthermore this downward api ref in scheduled runs ends up doing nothing: https://github.com/kubeflow/kfp-tekton/blob/master/sdk/python/kfp_tekton/compiler/_data_passing_rewriter.py#L826, because the annotation from which it is referencing also does not get created.
What did you expect to happen:
All instances of
ORIG_PR_NAME
are properly substituted for the PR name, just like for manually triggered runs.Additional information:
We are also using this attribute to work around: #1292
by identifying the locations of all the artifacts within the step copy artifact step, this unfortunately doesn't work if this variable is not properly substituted in a recurring run.
Environment:
tkn version
): 0.47kubectl version
): 1.26/etc/os-release
): fedora 37The text was updated successfully, but these errors were encountered: