Skip to content

Commit 1612dac

Browse files
papagalaOswaldo Gomez
andauthored
fix: Incorrect typing in samples/cores/loop_parallism and fixing loop_parameter examples (#11062)
* Fixing incorrect typing in loop_parallism example Signed-off-by: Oswaldo Gomez <oswaldo.gomez@roche.com> * Fixing samples/core/loop_parameter example Signed-off-by: Oswaldo Gomez <oswaldo.gomez@roche.com> --------- Signed-off-by: Oswaldo Gomez <oswaldo.gomez@roche.com> Co-authored-by: Oswaldo Gomez <oswaldo.gomez@roche.com>
1 parent ff4e918 commit 1612dac

File tree

2 files changed

+3
-5
lines changed

2 files changed

+3
-5
lines changed

samples/core/loop_parallelism/loop_parallelism.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
from kfp import compiler, dsl
1616

1717
@dsl.component()
18-
def print_op(s: str):
18+
def print_op(s: int):
1919
print(s)
2020

2121
@dsl.pipeline(name='my-pipeline')

samples/core/loop_parameter/loop_parameter.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,8 @@ def concat_op(a: str, b: str) -> str:
1414

1515

1616
@dsl.component
17-
def generate_op() -> str:
18-
import json
19-
return json.dumps([{'a': i, 'b': i * 10} for i in range(1, 5)])
20-
17+
def generate_op() -> list:
18+
return [{'a': i, 'b': i * 10} for i in range(1, 5)]
2119

2220
@dsl.pipeline(name='pipeline-with-loop-parameter')
2321
def my_pipeline(

0 commit comments

Comments
 (0)